MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-10-06 06:21:16 +07:00
Code Issues Packages Projects Releases Wiki Activity

runtime-chooser: IDEA-263881 - rework location field, simplify

Browse Source 
GitOrigin-RevId: 92619bc214f0aab1c20f284e9d57622be3b001f3
This commit is contained in:
Eugene Petrenko
2021-03-12 13:26:20 +00:00
committed by intellij-monorepo-bot
parent a42214723c
commit 71609445c4
2 changed files with 13 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/lang-api/resources/messages/LangBundle.properties
+1 -1
View File
@@ -534,6 +534,6 @@ dialog.separator.choose.ide.runtime.advancedJbrs=More Runtimes
dialog.separator.choose.ide.runtime.customSelected=Manually Added
dialog.button.choose.ide.runtime.useDefault=Use Default Runtime
dialog.title.choose.ide.runtime.select.path.to.install.jdk=Select Path to Download the IDE Boot Runtime
dialog.message.choose.ide.runtime.select.path.to.install.jdk=The selected boot runtime will be downloaded and set for the current IDE
dialog.message.choose.ide.runtime.select.path.to.install.jdk=The selected boot runtime will be downloaded if needed and set for the current IDE
dialog.label.choose.ide.runtime.warn=Changing the runtime may cause unexpected problems. Do not change it unless you were specifically asked to do so by JetBrains support.
project.view.elements.selected={0} elements selected
platform/lang-impl/src/com/intellij/openapi/projectRoots/impl/jdkDownloader/RuntimeChooserDialog.kt
+12 -31
View File
@@ -152,51 +152,32 @@ class RuntimeChooserDialog(
jdkCombobox.invoke(growX)
}
//download row
row(LangBundle.message("dialog.label.choose.ide.runtime.location")) {
val locationLabel = JBTextField()
locationLabel.isEditable = false
locationLabel.invoke(growX)
val updateLocation = {
(jdkCombobox.selectedItem as? RuntimeChooserItemWithFixedLocation)?.let { item ->
locationLabel.text = FileUtil.getLocationRelativeToUserHome(item.homeDir, false)
}
}
updateLocation()
jdkCombobox.addItemListener { updateLocation() }
}.onlyVisibleWhenSelected { it is RuntimeChooserItemWithFixedLocation }
//download row
row(LangBundle.message("dialog.label.choose.ide.runtime.location")) {
jdkInstallDirSelector = textFieldWithBrowseButton(
project = project,
browseDialogTitle = LangBundle.message("dialog.title.choose.ide.runtime.select.path.to.install.jdk"),
fileChooserDescriptor = FileChooserDescriptorFactory.createSingleFolderDescriptor()
).constraints(growX).component
).constraints(growX)
.comment(LangBundle.message("dialog.message.choose.ide.runtime.select.path.to.install.jdk"))
.component
val updateLocation = {
(jdkCombobox.selectedItem as? RuntimeChooserDownloadableItem)?.let { item ->
jdkInstallDirSelector.text = model.getDefaultInstallPathFor(item.item)
jdkInstallDirSelector.isEditable = true
jdkInstallDirSelector.setButtonEnabled(true)
}
(jdkCombobox.selectedItem as? RuntimeChooserItemWithFixedLocation)?.let { item ->
jdkInstallDirSelector.text = FileUtil.getLocationRelativeToUserHome(item.homeDir, false)
jdkInstallDirSelector.isEditable = false
jdkInstallDirSelector.setButtonEnabled(false)
}
}
updateLocation()
jdkCombobox.addItemListener { updateLocation() }
}.onlyVisibleWhenSelected { it is RuntimeChooserDownloadableItem }
row {
comment(LangBundle.message("dialog.message.choose.ide.runtime.select.path.to.install.jdk"))
}.onlyVisibleWhenSelected { it is RuntimeChooserDownloadableItem }
}
}
}
private fun Row.onlyVisibleWhenSelected(isVisible: (RuntimeChooserItem?) -> Boolean) {
val updateVisible = {
val visible = isVisible(jdkCombobox.selectedItem as? RuntimeChooserItem)
this@onlyVisibleWhenSelected.visible = visible
this@onlyVisibleWhenSelected.enabled = visible
}
updateVisible()
jdkCombobox.addItemListener { updateVisible() }
}
}