MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-04-19 21:11:28 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEABKL-3891

Browse Source
This commit is contained in:
Alexey Kudravtsev
2012-04-06 18:41:48 +04:00
parent af4860ff65
commit 713aa0a2b0
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/CreateLocalVarFromInstanceofAction.java
View File

@@ -36,6 +36,7 @@ import com.intellij.psi.codeStyle.SuggestedNameInfo;
import com.intellij.psi.codeStyle.VariableKind;
import com.intellij.psi.util.PsiTreeUtil;
import com.intellij.psi.util.PsiUtil;
import com.intellij.psi.util.TypeConversionUtil;
import com.intellij.refactoring.JavaRefactoringSettings;
import com.intellij.util.ArrayUtil;
import com.intellij.util.IncorrectOperationException;
@@ -59,9 +60,12 @@ public class CreateLocalVarFromInstanceofAction extends BaseIntentionAction {
if (instanceOfExpression == null) return false;
PsiTypeElement checkType = instanceOfExpression.getCheckType();
if (checkType == null) return false;
PsiExpression operand = instanceOfExpression.getOperand();
PsiType operandType = operand.getType();
if (TypeConversionUtil.isPrimitiveAndNotNull(operandType)) return false;
PsiType type = checkType.getType();
String castTo = type.getPresentableText();
setText(QuickFixBundle.message("create.local.from.instanceof.usage.text", castTo, instanceOfExpression.getOperand().getText()));
setText(QuickFixBundle.message("create.local.from.instanceof.usage.text", castTo, operand.getText()));
PsiStatement statement = PsiTreeUtil.getParentOfType(instanceOfExpression, PsiStatement.class);
boolean insideIf = statement instanceof PsiIfStatement

8
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/createLocalVarFromInstanceof/beforeComplexExpression.java Normal file
View File

@@ -0,0 +1,8 @@
// "Insert '(String)!o' declaration" "false"
class C {
void f(Object o, Object f) {
if (!o instanceof String) {
<caret>
}
}
}