Code coverage: when include a class for exclusion and save the item is added to include dialog box (IDEA-206286)

This commit is contained in:
Dmitry Batkovich
2019-02-25 17:45:11 +03:00
parent a7a6dddf29
commit 707eb35a6f
2 changed files with 10 additions and 9 deletions
@@ -181,7 +181,6 @@ public class ClassFilterEditor extends JPanel implements ComponentWithEmptyText
private final List<com.intellij.ui.classFilter.ClassFilter> myFilters = new LinkedList<>();
public static final int CHECK_MARK = 0;
public static final int FILTER = 1;
public static final int INCLUDE_MARK = 2;
public final void setFilters(com.intellij.ui.classFilter.ClassFilter[] filters) {
myFilters.clear();
@@ -243,9 +242,6 @@ public class ClassFilterEditor extends JPanel implements ComponentWithEmptyText
if (columnIndex == CHECK_MARK) {
return filter.isEnabled();
}
if (columnIndex == INCLUDE_MARK) {
return filter.isInclude();
}
return null;
}
@@ -258,16 +254,13 @@ public class ClassFilterEditor extends JPanel implements ComponentWithEmptyText
else if (columnIndex == CHECK_MARK) {
filter.setEnabled(aValue == null || ((Boolean)aValue).booleanValue());
}
else if (columnIndex == INCLUDE_MARK) {
filter.setInclude(aValue == null || ((Boolean)aValue).booleanValue());
}
// fireTableCellUpdated(rowIndex, columnIndex);
fireTableRowsUpdated(rowIndex, rowIndex);
}
@Override
public Class getColumnClass(int columnIndex) {
if (columnIndex == CHECK_MARK || columnIndex == INCLUDE_MARK) {
if (columnIndex == CHECK_MARK) {
return Boolean.class;
}
return super.getColumnClass(columnIndex);
@@ -266,7 +266,15 @@ public class CoverageConfigurable extends SettingsEditor<RunConfigurationBase> {
panel.add(myClassFilterEditor, bagConstraints);
panel.add(new TitledSeparator(ExecutionBundle.message("exclude.coverage.filters.title")), bagConstraints);
myExcludeClassFilterEditor = new MyClassFilterEditor(myProject);
myExcludeClassFilterEditor = new MyClassFilterEditor(myProject) {
@NotNull
@Override
protected ClassFilter createFilter(String pattern) {
ClassFilter filter = super.createFilter(pattern);
filter.setInclude(false);
return filter;
}
};
panel.add(myExcludeClassFilterEditor, bagConstraints);
bagConstraints.weighty = 0;