add initial devkit NonDefaultConstructor inspection

2026-09-27 10:03:11 +07:00 · 2019-01-31 19:20:20 +01:00
parent 4f9d60d29d
commit 6f338eb6bd
3 changed files with 53 additions and 0 deletions
@@ -179,6 +179,10 @@
                     displayName="Using PsiElement string representation to generate new expression is incorrect"
                     groupKey="inspections.group.name" enabledByDefault="true" level="WARNING"
                     implementationClass="org.jetbrains.idea.devkit.inspections.PsiElementConcatenationInspection"/>
+    <localInspection language="UAST" shortName="NonDefaultConstructor" displayName="Non default constructors for bean extension class"
+                     groupKey="inspections.group.name"
+                     enabledByDefault="true" level="ERROR"
+                     implementationClass="org.jetbrains.idea.devkit.inspections.NonDefaultConstructorInspection"/>
    <localInspection language="UAST" shortName="PresentationAnnotation" displayName="Invalid icon path in @Presentation"
                     groupKey="inspections.group.name"
                     enabledByDefault="true" level="ERROR"
@@ -0,0 +1,5 @@
+<html>
+<body>
+Validates that bean extension class has only default constructor.
+</body>
+</html>
@@ -0,0 +1,44 @@
+// Copyright 2000-2019 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
+package org.jetbrains.idea.devkit.inspections
+
+import com.intellij.codeInspection.InspectionManager
+import com.intellij.codeInspection.ProblemDescriptor
+import com.intellij.codeInspection.ProblemHighlightType
+import com.intellij.lang.jvm.JvmClassKind
+import com.intellij.util.SmartList
+import org.jetbrains.uast.UClass
+
+internal class NonDefaultConstructorInspection : DevKitUastInspectionBase() {
+  override fun checkClass(aClass: UClass, manager: InspectionManager, isOnTheFly: Boolean): Array<ProblemDescriptor>? {
+    if (!isExtensionBean(aClass)) {
+      return null
+    }
+
+    var errors: MutableList<ProblemDescriptor>? = null
+    for (method in aClass.javaPsi.constructors) {
+      if (method.hasParameters()) {
+        if (errors == null) {
+          errors = SmartList()
+        }
+        errors.add(manager.createProblemDescriptor(method ?: continue,
+                                                   "Bean extension class should not have constructor with parameters", true,
+                                                   ProblemHighlightType.ERROR, isOnTheFly))
+      }
+    }
+    return errors?.toTypedArray()
+  }
+}
+
+private fun isExtensionBean(aClass: UClass): Boolean {
+  if (aClass.javaPsi.classKind != JvmClassKind.CLASS) {
+    return false
+  }
+
+  var p = aClass
+  while (true) {
+    p = p.superClass ?: return false
+    if (p.qualifiedName == "com.intellij.openapi.extensions.AbstractExtensionPointBean") {
+      return true
+    }
+  }
+}