MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-01-06 03:21:12 +07:00
Code Issues Packages Projects Releases Wiki Activity

[DS-5033] catch exceptions from NotebookOutputComponentFactory, log them and allow other factories to work

Browse Source 
GitOrigin-RevId: 630c7049d04c813661db5de13d70462e5306346d
This commit is contained in:
Igor Slobodskov
2023-09-01 13:51:12 +02:00
committed by intellij-monorepo-bot
parent 8022687f88
commit 6d5a39c537
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
notebooks/visualization/src/org/jetbrains/plugins/notebooks/visualization/outputs/NotebookOutputInlayController.kt
View File

@@ -5,6 +5,7 @@ import com.intellij.openapi.application.ApplicationManager
import com.intellij.openapi.components.Service
import com.intellij.openapi.components.service
import com.intellij.openapi.diagnostic.logger
import com.intellij.openapi.diagnostic.thisLogger
import com.intellij.openapi.editor.Document
import com.intellij.openapi.editor.Editor
import com.intellij.openapi.editor.EditorCustomElementRenderer
@@ -14,7 +15,9 @@ import com.intellij.openapi.util.Disposer
import com.intellij.util.asSafely
import com.intellij.util.messages.Topic
import org.jetbrains.plugins.notebooks.ui.visualization.notebookAppearance
import org.jetbrains.plugins.notebooks.visualization.*
import org.jetbrains.plugins.notebooks.visualization.NotebookCellInlayController
import org.jetbrains.plugins.notebooks.visualization.NotebookCellLines
import org.jetbrains.plugins.notebooks.visualization.SwingClientProperty
import org.jetbrains.plugins.notebooks.visualization.outputs.NotebookOutputComponentFactory.Companion.gutterPainter
import org.jetbrains.plugins.notebooks.visualization.outputs.impl.CollapsingComponent
import org.jetbrains.plugins.notebooks.visualization.outputs.impl.InnerComponent
@@ -226,7 +229,14 @@ class NotebookOutputInlayController private constructor(
private fun <K : NotebookOutputDataKey> createOutput(factory: NotebookOutputComponentFactory<*, K>,
outputDataKey: K): NotebookOutputComponentFactory.CreatedComponent<*>? {
ApplicationManager.getApplication().messageBus.syncPublisher(OUTPUT_LISTENER).beforeOutputCreated(editor, lines.last)
val result = factory.createComponent(editor, outputDataKey)?.also {
val result = try {
factory.createComponent(editor, outputDataKey)
}
catch (t: Throwable) {
thisLogger().error("${factory.javaClass.name} shouldn't throw exceptions at .createComponent()", t)
null
}
result?.also {
it.component.outputComponentFactory = factory
it.component.gutterPainter = it.gutterPainter
}