[vcs-log] minor: remove some duplications

This commit is contained in:
Julia Beliaeva
2014-12-20 18:59:41 +03:00
parent 9b4c37d31c
commit 6c5b403549
2 changed files with 15 additions and 12 deletions
@@ -232,6 +232,7 @@ class DetailsPanel extends JPanel implements ListSelectionListener {
private static class DataPanel extends JEditorPane {
public static final int BRANCHES_LIMIT = 6;
public static final int BRANCHES_TABLE_COLUMN_COUNT = 3;
@NotNull public static final String LEFT_ALIGN = "left";
@NotNull private static String SHOW_OR_HIDE_BRANCHES = "Show or Hide Branches";
@NotNull private final Project myProject;
@@ -328,9 +329,9 @@ class DetailsPanel extends JPanel implements ListSelectionListener {
if (index >= myBranches.size()) {
builder.append("");
} else if (index != myBranches.size() - 1) {
builder.append(myBranches.get(index) + "," + StringUtil.repeat(" ", 20), "left");
builder.append(myBranches.get(index) + "," + StringUtil.repeat(" ", 20), LEFT_ALIGN);
} else {
builder.append(myBranches.get(index), "left");
builder.append(myBranches.get(index), LEFT_ALIGN);
}
}
@@ -15,8 +15,11 @@
*/
package com.intellij.vcs.log.ui.frame;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
public class HtmlTableBuilder {
private final StringBuilder myStringBuilder = new StringBuilder();
@NotNull private final StringBuilder myStringBuilder = new StringBuilder();
public HtmlTableBuilder() {
myStringBuilder.append("<table>");
@@ -32,17 +35,16 @@ public class HtmlTableBuilder {
return this;
}
public HtmlTableBuilder append(String value) {
myStringBuilder.append("<td>");
myStringBuilder.append(value);
myStringBuilder.append("</td>");
return this;
public HtmlTableBuilder append(@NotNull String value) {
return append(value, null);
}
public HtmlTableBuilder append(String value, String align) {
myStringBuilder.append("<td align=\"").append(align).append("\">");
myStringBuilder.append(value);
myStringBuilder.append("</td>");
public HtmlTableBuilder append(@NotNull String value, @Nullable String align) {
myStringBuilder.append("<td");
if (align != null) {
myStringBuilder.append(" align=\"").append(align).append("\"");
}
myStringBuilder.append(">").append(value).append("</td>");
return this;
}