MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

Revert 5b456c95: not only incomplete fix for IDEA-132259, but even incorrect: IDEA-142611

Browse Source
This commit is contained in:
Kirill Likhodedov
2015-07-17 18:25:51 +03:00
parent a6fae648a0
commit 6b22a503af
1 changed files with 5 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/git4idea/src/git4idea/ui/branch/GitBranchPopupActions.java
+5 -13
View File
@@ -24,8 +24,6 @@ import com.intellij.openapi.components.ServiceManager;
import com.intellij.openapi.project.DumbAwareAction;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.ui.Messages;
import com.intellij.openapi.util.Condition;
import com.intellij.util.containers.ContainerUtil;
import git4idea.GitBranch;
import git4idea.branch.GitBranchUtil;
import git4idea.branch.GitBrancher;
@@ -284,31 +282,25 @@ class GitBranchPopupActions {
@NotNull String remoteBranchName) {
super("Checkout as new local branch");
myProject = project;
myRepositories = repositories;
myRemoteBranchName = remoteBranchName;
myRepositories = ContainerUtil.filter(repositories, new Condition<GitRepository>() {
@Override
public boolean value(GitRepository repository) {
return !guessBranchName(myRemoteBranchName).equals(repository.getCurrentBranchName());
}
});
}
@Override
public void actionPerformed(AnActionEvent e) {
final String name = Messages.showInputDialog(myProject, "Enter name of new branch", "Checkout Remote Branch", Messages.getQuestionIcon(),
guessBranchName(myRemoteBranchName),
GitNewBranchNameValidator.newInstance(myRepositories));
guessBranchName(), GitNewBranchNameValidator.newInstance(myRepositories));
if (name != null) {
GitBrancher brancher = ServiceManager.getService(myProject, GitBrancher.class);
brancher.checkoutNewBranchStartingFrom(name, myRemoteBranchName, myRepositories, null);
}
}
private static String guessBranchName(@NotNull String remoteBranchName) {
private String guessBranchName() {
// TODO: check if we already have a branch with that name; check if that branch tracks this remote branch. Show different messages
int slashPosition = remoteBranchName.indexOf("/");
int slashPosition = myRemoteBranchName.indexOf("/");
// if no slash is found (for example, in the case of git-svn remote branches), propose the whole name.
return remoteBranchName.substring(slashPosition + 1);
return myRemoteBranchName.substring(slashPosition+1);
}
}