MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

dfa: fix & treatment

Browse Source
This commit is contained in:
peter
2013-09-12 22:15:05 +04:00
parent 1af2b843bd
commit 6af48bbd0a
3 changed files with 17 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/ControlFlowAnalyzer.java
+1 -1
View File
@@ -1163,7 +1163,7 @@ class ControlFlowAnalyzer extends JavaElementVisitor {
if (!shortCircuit) {
if (i > 0) {
combineStackBooleans(false, operand);
combineStackBooleans(true, operand);
}
continue;
}
java/java-tests/testData/inspection/dataFlow/boxingBoolean/expected.xml
-5
View File
@@ -36,9 +36,4 @@
<description>Condition &lt;code&gt;o&lt;/code&gt; at the left side of assignment expression is always &lt;code&gt;false&lt;/code&gt;. Can be simplified to normal assignment.</description>
</problem>
<problem>
<file>Test.java</file>
<line>52</line>
<description>Condition &lt;code&gt;o&lt;/code&gt; is always &lt;code&gt;true&lt;/code&gt;</description>
</problem>
</problems>
java/java-tests/testData/inspection/dataFlow/fixture/LongCircuitOperations.java
+16 -1
View File
@@ -1,3 +1,5 @@
import org.jetbrains.annotations.NotNull;
class X {
int foo(String d1, String d2) {
@@ -7,7 +9,7 @@ class X {
}
void foo2(String d1, String d2) {
if(<warning descr="Condition 'd1 == null & d1 != null' is always 'true'">d1 == null & d1 != null</warning>)
if(<warning descr="Condition 'd1 == null & d1 != null' is always 'false'">d1 == null & d1 != null</warning>)
System.out.println("impossible");
}
@@ -17,3 +19,16 @@ class X {
}
}
class Doo {
void zoo(@NotNull Object t, @NotNull Object s) {
}
private void goo(Object t, Object t2) {
if (t != null & t2 != null) {
zoo(t, t2);
}
}
}