MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

StringConcatenationInLoop#isAppended: check whether polyadic expression is actually a concatenation (IDEA-CR-16590)

Browse Source
This commit is contained in:
Tagir Valeev
2016-12-28 13:11:33 +07:00
parent 5513e21fdc
commit 69c86b0b45
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/performance/StringConcatenationInLoopsInspection.java
+5 -2
View File
@@ -215,8 +215,11 @@ public class StringConcatenationInLoopsInspection extends BaseInspection {
private static boolean isAppended(PsiVariable variable, PsiExpression expression) {
expression = PsiUtil.skipParenthesizedExprDown(expression);
if(expression instanceof PsiPolyadicExpression) {
for(PsiExpression operand : ((PsiPolyadicExpression)expression).getOperands()) {
if(ExpressionUtils.isReferenceTo(operand, variable) || isAppended(variable, operand)) return true;
PsiPolyadicExpression polyadicExpression = (PsiPolyadicExpression)expression;
if (polyadicExpression.getOperationTokenType().equals(JavaTokenType.PLUS)) {
for (PsiExpression operand : polyadicExpression.getOperands()) {
if (ExpressionUtils.isReferenceTo(operand, variable) || isAppended(variable, operand)) return true;
}
}
}
return false;
plugins/InspectionGadgets/test/com/siyeh/igtest/performance/string_concatenation_in_loops/StringConcatenationInLoop.java
+6
View File
@@ -94,6 +94,12 @@ public class StringConcatenationInLoop
System.out.println(s);
}
}
for (int i = 0; i < 10; i++) {
s = (s == "") + "...";
}
for (int i = 0; i < 10; i++) {
s = ("xyz" <warning descr="String concatenation '+' in loop">+</warning> (i <warning descr="String concatenation '+' in loop">+</warning> s)) <warning descr="String concatenation '+' in loop">+</warning> "...";
}
System.out.println(foo);
return foo;
}