MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

inspections: run global inspections remembers last selected profile per project (IDEA-164817)

Browse Source
This commit is contained in:
Dmitry Batkovich
2016-12-01 17:34:47 +03:00
parent 4203dadabf
commit 69721c6a13
1 changed files with 27 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/lang-impl/src/com/intellij/codeInspection/actions/CodeInspectionAction.java
+27 -1
View File
@@ -25,6 +25,8 @@ import com.intellij.codeInspection.ex.GlobalInspectionContextImpl;
import com.intellij.codeInspection.ex.InspectionManagerEx;
import com.intellij.codeInspection.ex.InspectionProfileImpl;
import com.intellij.codeInspection.ex.InspectionProfileModifiableModel;
import com.intellij.ide.util.PropertiesComponent;
import com.intellij.openapi.diagnostic.Logger;
import com.intellij.openapi.fileEditor.FileDocumentManager;
import com.intellij.openapi.options.ex.SingleConfigurableEditor;
import com.intellij.openapi.project.Project;
@@ -45,6 +47,9 @@ import java.util.ArrayList;
import java.util.List;
public class CodeInspectionAction extends BaseAnalysisAction {
private static final Logger LOG = Logger.getInstance(CodeInspectionAction.class);
private static final String LAST_SELECTED_PROFILE_PROP = "run.code.analysis.last.selected.profile";
private GlobalInspectionContextImpl myGlobalInspectionContext;
protected InspectionProfileImpl myExternalProfile;
@@ -127,6 +132,7 @@ public class CodeInspectionAction extends BaseAnalysisAction {
final boolean canExecute = myExternalProfile != null && myExternalProfile.isExecutable(project);
dialog.setOKActionEnabled(canExecute);
if (canExecute) {
PropertiesComponent.getInstance(project).setValue(LAST_SELECTED_PROFILE_PROP, (myExternalProfile.isProjectLevel() ? 'p' : 'a') + myExternalProfile.getName());
manager.setProfile(myExternalProfile.getName());
}
}
@@ -178,7 +184,7 @@ public class CodeInspectionAction extends BaseAnalysisAction {
InspectionProfileManager inspectionProfileManager,
InspectionProjectProfileManager inspectionProjectProfileManager,
InspectionManagerEx inspectionManager) {
InspectionProfileImpl selectedProfile = getGlobalInspectionContext(inspectionManager.getProject()).getCurrentProfile();
InspectionProfileImpl selectedProfile = getProfileToUse(inspectionManager.getProject(), inspectionProfileManager, inspectionProjectProfileManager);
List<InspectionProfileImpl> profiles = new ArrayList<>();
profiles.addAll(inspectionProfileManager.getProfiles());
profiles.addAll(inspectionProjectProfileManager.getProfiles());
@@ -186,6 +192,26 @@ public class CodeInspectionAction extends BaseAnalysisAction {
profilesCombo.selectProfile(selectedProfile);
}
@NotNull
private InspectionProfileImpl getProfileToUse(@NotNull Project project,
@NotNull InspectionProfileManager appProfileManager,
@NotNull InspectionProjectProfileManager projectProfileManager) {
final String lastSelectedProfile = PropertiesComponent.getInstance(project).getValue(LAST_SELECTED_PROFILE_PROP);
if (lastSelectedProfile != null) {
final char type = lastSelectedProfile.charAt(0);
final String lastSelectedProfileName = lastSelectedProfile.substring(1);
if (type == 'a') {
final InspectionProfileImpl profile = appProfileManager.getProfile(lastSelectedProfileName, false);
if (profile != null) return profile;
} else {
LOG.assertTrue(type == 'p', "Unexpected last selected profile: \'" + lastSelectedProfile + "\'");
final InspectionProfileImpl profile = projectProfileManager.getProfile(lastSelectedProfileName, false);
if (profile != null && profile.isProjectLevel()) return profile;
}
}
return getGlobalInspectionContext(project).getCurrentProfile();
}
private static class AdditionalPanel {
public ComboboxWithBrowseButton myBrowseProfilesCombo;
public JPanel myAdditionalPanel;