MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-04-20 21:41:24 +07:00
Code Issues Packages Projects Releases Wiki Activity

suggest 'final' in for-in loop clause (IDEA-67249)

Browse Source
This commit is contained in:
peter
2011-03-30 15:13:51 +02:00
parent 4b5428e738
commit 68d8890b7f
3 changed files with 21 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
java/java-impl/src/com/intellij/codeInsight/completion/JavaCompletionData.java
View File

@@ -526,9 +526,12 @@ public class JavaCompletionData extends JavaAwareCompletionData{
return;
}
final PsiExpressionStatement expressionStatement = PsiTreeUtil.getParentOfType(position, PsiExpressionStatement.class);
if (expressionStatement != null && expressionStatement.getTextRange().getStartOffset() == position.getTextRange().getStartOffset()) {
if (!psiElement().withSuperParent(2, PsiSwitchStatement.class).accepts(expressionStatement)) {
PsiStatement statement = PsiTreeUtil.getParentOfType(position, PsiExpressionStatement.class);
if (statement == null) {
statement = PsiTreeUtil.getParentOfType(position, PsiDeclarationStatement.class);
}
if (statement != null && statement.getTextRange().getStartOffset() == position.getTextRange().getStartOffset()) {
if (!psiElement().withSuperParent(2, PsiSwitchStatement.class).accepts(statement)) {
result.addElement(createKeyword(position, PsiKeyword.FINAL));
}
}

9
java/java-tests/testData/codeInsight/completion/normal/FinalInForLoop2.java Normal file
View File

@@ -0,0 +1,9 @@
import java.util.ArrayList;
public class Foooo {
{
for (fin<caret> Object o : new ArrayList())
}
}

8
java/java-tests/testSrc/com/intellij/codeInsight/completion/NormalCompletionTest.groovy
View File

@@ -709,8 +709,12 @@ public class NormalCompletionTest extends LightFixtureCompletionTestCase {
public void testFinalInForLoop() throws Throwable {
configure()
checkResultByFile(getTestName(false) + ".java")
assertOrderedEquals myFixture.lookupElementStrings, 'final'
assertStringItems 'final'
}
public void testFinalInForLoop2() throws Throwable {
configure()
assertStringItems 'final', 'finalize'
}
public void testPrimitiveTypesInForLoop() throws Throwable { doPrimitiveTypeTest() }