cleanup

platform/lang-impl/src/com/intellij/codeInsight/template/actions/SaveAsTemplateAction.java

@@ -94,7 +94,7 @@ public class SaveAsTemplateAction extends AnAction {
                   String canonicalText = reference.getCanonicalText();
                   TextRange referenceRange = reference.getRangeInElement();
                   TextRange range = element.getTextRange().cutOut(referenceRange).shiftRight(-offsetDelta);
-                  final String oldText = range.substring(document.getText());
+                  final String oldText = document.getText(range);
                   if (!canonicalText.equals(oldText)) {
                     rangeToText.put(document.createRangeMarker(range), canonicalText);
                   }

platform/lang-impl/src/com/intellij/execution/console/LanguageConsoleImpl.java

@@ -354,7 +354,7 @@ public class LanguageConsoleImpl implements Disposable, TypeSafeDataProvider {
                                     HighlighterTargetArea.EXACT_RANGE);
 
     final int offset = history.getTextLength();
-    final String text = textRange.substring(consoleEditor.getDocument().getText());
+    final String text = consoleEditor.getDocument().getText(textRange);
     history.insertString(offset, text);
     final HighlighterIterator iterator = consoleEditor.getHighlighter().createIterator(0);
     while (!iterator.atEnd()) {

platform/lang-impl/src/com/intellij/refactoring/ui/NameSuggestionsField.java

@@ -93,7 +93,7 @@ public class NameSuggestionsField extends JPanel {
         Editor myEditor = getEditor();
         if (myEditor == null) return;
         for (TextRange wordRange : ranges) {
-          String word = wordRange.substring(editor.getDocument().getText());
+          String word = editor.getDocument().getText(wordRange);
           if (!word.equals(getEnteredName())) continue;
           final SelectionModel selectionModel = editor.getSelectionModel();
           myEditor.getSelectionModel().removeSelection();

platform/platform-api/src/com/intellij/openapi/editor/Document.java

@@ -49,7 +49,7 @@ public interface Document extends UserDataHolder {
    */
   String getText();
 
-  String getText(TextRange range);
+  @NotNull String getText(@NotNull TextRange range);
 
   /**
    * Use this method instead of {@link #getText()} if you do not need to create a copy of the content.

platform/platform-impl/src/com/intellij/openapi/diff/actions/MergeOperations.java

@@ -143,7 +143,7 @@ public class MergeOperations {
   }
 
   private static String getSubstring(Document document, TextRange range) {
-    return range.substring(document.getText());
+    return document.getText(range);
   }
 
   private Document getOtherDocument() {

platform/platform-impl/src/com/intellij/openapi/editor/textarea/TextComponentDocument.java

@@ -50,8 +50,9 @@ public class TextComponentDocument extends UserDataHolderBase implements Documen
     }
   }
 
+  @NotNull
   @Override
-  public String getText(TextRange range) {
+  public String getText(@NotNull TextRange range) {
     try {
       final javax.swing.text.Document document = myTextComponent.getDocument();
       return document.getText(range.getStartOffset(), range.getLength());

platform/xdebugger-impl/src/com/intellij/xdebugger/impl/actions/handlers/XAddToWatchesFromEditorActionHandler.java

@@ -54,7 +54,7 @@ public class XAddToWatchesFromEditorActionHandler extends XDebuggerActionHandler
           final Document document = editor.getDocument();
           final TextRange textRange = evaluator.getExpressionRangeAtOffset(session.getProject(), document, offset);
           if (textRange != null) {
-            text = textRange.substring(document.getText());
+            text = document.getText(textRange);
           }
         }
       }

platform/xdebugger-impl/src/com/intellij/xdebugger/impl/evaluate/quick/XValueHint.java

@@ -62,7 +62,7 @@ public class XValueHint extends AbstractValueHint {
     myEvaluator = evaluator;
     myDebugSession = session;
     final Document document = editor.getDocument();
-    myExpression = textRange.substring(document.getText());
+    myExpression = document.getText(textRange);
     final VirtualFile file = FileDocumentManager.getInstance().getFile(document);
     myExpressionPosition = file != null ? XDebuggerUtil.getInstance().createPositionByOffset(file, textRange.getStartOffset()) : null;
   }

plugins/java-i18n/src/com/intellij/codeInspection/i18n/I18nizeAction.java

@@ -197,7 +197,7 @@ public class I18nizeAction extends AnAction implements I18nQuickFixHandler{
 
     TextRange selectedRange = getSelectedRange(editor, psiFile);
     if (selectedRange == null) return null;
-    String text = selectedRange.substring(editor.getDocument().getText());
+    String text = editor.getDocument().getText(selectedRange);
     return new JavaI18nizeQuickFixDialog(project, jspFile, null, text, null, false, true){
       protected String getTemplateName() {
         return JavaTemplateUtil.TEMPLATE_I18NIZED_JSP_EXPRESSION;

plugins/spellchecker/src/com/intellij/spellchecker/inspections/BaseSplitter.java

@@ -100,7 +100,7 @@ public abstract class BaseSplitter implements Splitter {
     int from = range.getStartOffset();
     int till;
     boolean addLast = true;
-    Matcher matcher = toExclude.matcher(text.substring(range.getStartOffset(), range.getEndOffset()));
+    Matcher matcher = toExclude.matcher(range.substring(text));
     while (matcher.find()) {
 
       checkCancelled();

plugins/spellchecker/src/com/intellij/spellchecker/inspections/CheckArea.java

@@ -48,7 +48,7 @@ public class CheckArea {
   @Nullable
   public String getWord() {
     if (text == null || textRange == null) return null;
-    return text.substring(textRange.getStartOffset(), textRange.getEndOffset());
+    return textRange.substring(text);
   }
 
   @Override

plugins/spellchecker/src/com/intellij/spellchecker/inspections/PlainTextSplitter.java

@@ -38,7 +38,7 @@ public class PlainTextSplitter extends BaseSplitter {
     if (text == null || StringUtil.isEmpty(text)) {
       return null;
     }
-    if (Verifier.checkCharacterData(text.substring(range.getStartOffset(), range.getEndOffset())) != null) {
+    if (Verifier.checkCharacterData(range.substring(text)) != null) {
       return null;
     }
 

plugins/spellchecker/src/com/intellij/spellchecker/inspections/PropertiesSplitter.java

@@ -40,7 +40,7 @@ public class PropertiesSplitter extends BaseSplitter {
     }
     List<CheckArea> results = new ArrayList<CheckArea>();
     final IdentifierSplitter splitter = SplitterFactory.getInstance().getIdentifierSplitter();
-    Matcher matcher = WORD.matcher(text.substring(range.getStartOffset(), range.getEndOffset()));
+    Matcher matcher = WORD.matcher(range.substring(text));
     while (matcher.find()) {
       if (matcher.end() - matcher.start() < MIN_RANGE_LENGTH) {
         continue;

plugins/spellchecker/src/com/intellij/spellchecker/inspections/TextSplitter.java

@@ -41,7 +41,7 @@ public class TextSplitter extends BaseSplitter {
   protected void doSplit(@NotNull String text, @NotNull TextRange range, List<CheckArea> results) {
     Matcher matcher;
     final WordSplitter ws = SplitterFactory.getInstance().getWordSplitter();
-    matcher = EXTENDED_WORD_AND_SPECIAL.matcher(text.substring(range.getStartOffset(), range.getEndOffset()));
+    matcher = EXTENDED_WORD_AND_SPECIAL.matcher(range.substring(text));
     while (matcher.find()) {
       TextRange found = matcherRange(range, matcher);
 

plugins/spellchecker/src/com/intellij/spellchecker/inspections/WordSplitter.java

@@ -39,7 +39,7 @@ public class WordSplitter extends BaseSplitter {
     }
     List<CheckArea> results = new ArrayList<CheckArea>();
 
-    Matcher specialMatcher = SPECIAL.matcher(text.substring(range.getStartOffset(), range.getEndOffset()));
+    Matcher specialMatcher = SPECIAL.matcher(range.substring(text));
     if (specialMatcher.find()) {
       TextRange found = matcherRange(range, specialMatcher);
       addWord(text, results, true, found);