MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

unnecessary qualified static usage: check also inner classes (IDEA-87870)

Browse Source
This commit is contained in:
anna
2012-07-03 20:21:20 +02:00
parent d452b01380
commit 67ba56ff43
3 changed files with 30 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/src/com/siyeh/ig/style/UnnecessarilyQualifiedStaticUsageInspection.java
+1 -1
View File
@@ -182,7 +182,7 @@ public class UnnecessarilyQualifiedStaticUsageInspection
PsiClass.class);
final PsiClass qualifyingClass = (PsiClass)resolvedQualifier;
if (containingClass == null ||
!containingClass.equals(qualifyingClass)) {
!PsiTreeUtil.isAncestor(qualifyingClass, containingClass, false)) {
return false;
}
final Project project = referenceElement.getProject();
plugins/InspectionGadgets/test/com/siyeh/igtest/style/unnecessarily_qualified_static_usage/UnnecessarilyQualifiedStaticUsageInspection.java
+15
View File
@@ -65,4 +65,19 @@ class X {
l.add("b");
l.add("c");
}
}
class InnerClassTest {
public static int foo = 0;
public static void bar() {
System.out.println();
}
public static class Inner {
public void test1() {
InnerClassTest.bar(); // (1)
System.out.println(InnerClassTest.foo); // (2)
}
}
}
plugins/InspectionGadgets/test/com/siyeh/igtest/style/unnecessarily_qualified_static_usage/expected.xml
+14
View File
@@ -36,6 +36,20 @@
<line>64</line>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Unnecessarily qualified static access</problem_class>
<description>Unnecessarily qualified static access &lt;code&gt;X.l&lt;/code&gt; #loc</description>
</problem>
<problem>
<file>UnnecessarilyQualifiedStaticUsageInspection.java</file>
<line>79</line>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Unnecessarily qualified static access</problem_class>
<description>Unnecessarily qualified static method call &lt;code&gt;InnerClassTest.bar()&lt;/code&gt; #loc</description>
</problem>
<problem>
<file>UnnecessarilyQualifiedStaticUsageInspection.java</file>
<line>80</line>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Unnecessarily qualified static access</problem_class>
<description>Unnecessarily qualified static access &lt;code&gt;InnerClassTest.foo&lt;/code&gt; #loc</description>
</problem>
</problems>