MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-18 09:34:34 +07:00
Code Issues Packages Projects Releases Wiki Activity

do not get through class/lambda during detection of container sync (IDEA-136805)

Browse Source
This commit is contained in:
Anna Kozlova
2015-02-20 19:46:48 +01:00
parent 939c490895
commit 66e83ed9ae
1 changed files with 7 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/threading/SleepWhileHoldingLockInspection.java
+7 -12
View File
@@ -45,9 +45,7 @@ public class SleepWhileHoldingLockInspection extends BaseInspection {
return new SleepWhileHoldingLockVisitor();
}
private static class SleepWhileHoldingLockVisitor
extends BaseInspectionVisitor {
private static class SleepWhileHoldingLockVisitor extends BaseInspectionVisitor {
@Override
public void visitMethodCallExpression(
@NotNull PsiMethodCallExpression expression) {
@@ -59,16 +57,14 @@ public class SleepWhileHoldingLockInspection extends BaseInspection {
if (!"sleep".equals(methodName)) {
return;
}
final PsiMethod containingMethod =
PsiTreeUtil.getParentOfType(expression, PsiMethod.class);
final PsiMethod containingMethod =
PsiTreeUtil.getParentOfType(expression, PsiMethod.class, true, PsiClass.class, PsiLambdaExpression.class);
boolean isSynced = false;
if (containingMethod != null && containingMethod
.hasModifierProperty(PsiModifier.SYNCHRONIZED)) {
if (containingMethod != null && containingMethod.hasModifierProperty(PsiModifier.SYNCHRONIZED)) {
isSynced = true;
}
final PsiSynchronizedStatement containingSyncStatement =
PsiTreeUtil.getParentOfType(expression,
PsiSynchronizedStatement.class);
final PsiSynchronizedStatement containingSyncStatement =
PsiTreeUtil.getParentOfType(expression, PsiSynchronizedStatement.class, true, PsiClass.class, PsiLambdaExpression.class);
if (containingSyncStatement != null) {
isSynced = true;
}
@@ -81,8 +77,7 @@ public class SleepWhileHoldingLockInspection extends BaseInspection {
}
final PsiClass methodClass = method.getContainingClass();
if (methodClass == null ||
!InheritanceUtil.isInheritor(methodClass,
"java.lang.Thread")) {
!InheritanceUtil.isInheritor(methodClass, "java.lang.Thread")) {
return;
}
registerMethodCallError(expression);