MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-03-22 06:50:54 +07:00
Code Issues Packages Projects Releases Wiki Activity

[pycharm] PY-73958 PyDefUseUtil: restrict resolve for large control flow graph to avoid recursion

Browse Source 
GitOrigin-RevId: 777dd787f0b992be0775e8844026345b4722cdf0
This commit is contained in:
Vladimir Koshelev
2024-07-30 17:55:04 +02:00
committed by intellij-monorepo-bot
parent 60f1bdbd8b
commit 660bdd70bb
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
python/python-psi-impl/src/com/jetbrains/python/refactoring/PyDefUseUtil.java
View File

@@ -44,6 +44,8 @@ public final class PyDefUseUtil {
private PyDefUseUtil() {
}
private static final int MAX_CONTROL_FLOW_SIZE = 200;
@NotNull
public static List<Instruction> getLatestDefs(ScopeOwner block, String varName, PsiElement anchor, boolean acceptTypeAssertions,
boolean acceptImplicitImports, @NotNull TypeEvalContext context) {
@@ -88,8 +90,9 @@ public final class PyDefUseUtil {
}
// not a back edge
if (instruction.num() < startNum && context.getOrigin() == callInstruction.getElement().getContainingFile()) {
var newContext = TypeEvalContext.codeAnalysis(context.getOrigin().getProject(),
context.getOrigin());
var newContext = (MAX_CONTROL_FLOW_SIZE > instructions.length)
? TypeEvalContext.codeAnalysis(context.getOrigin().getProject(), context.getOrigin())
: TypeEvalContext.codeInsightFallback(context.getOrigin().getProject());
if (callInstruction.isNoReturnCall(newContext)) return ControlFlowUtil.Operation.CONTINUE;
}
}
@@ -99,8 +102,9 @@ public final class PyDefUseUtil {
&& instruction instanceof ConditionalInstruction conditionalInstruction
&& instruction.num() < startNum) {
if (conditionalInstruction.getCondition() instanceof PyTypedElement typedElement && context.getOrigin() == typedElement.getContainingFile()) {
var newContext = TypeEvalContext.codeAnalysis(context.getOrigin().getProject(),
context.getOrigin());
var newContext = (MAX_CONTROL_FLOW_SIZE > instructions.length)
? TypeEvalContext.codeAnalysis(context.getOrigin().getProject(), context.getOrigin())
: TypeEvalContext.codeInsightFallback(context.getOrigin().getProject());
if (newContext.getType(typedElement) instanceof PyNarrowedType narrowedType) {
if (narrowedType.getQname().equals(varName)) {
pendingTypeGuard.put(narrowedType.getOriginal(), conditionalInstruction);