MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

LightReferenceListBuilder: less caching, don't resolve class types upon addition

Browse Source 
because resolve might be expensive, and sometimes lead to SOE if it requests the same lazily calculated reference list on the same class
This commit is contained in:
peter
2018-11-07 16:22:59 +01:00
parent c5c76ee6c5
commit 65295ceeee
1 changed files with 3 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-psi-impl/src/com/intellij/psi/impl/light/LightReferenceListBuilder.java
+3 -13
View File
@@ -28,7 +28,6 @@ import java.util.List;
*/
public class LightReferenceListBuilder extends LightElement implements PsiReferenceList {
private final List<PsiJavaCodeReferenceElement> myRefs = new ArrayList<>();
private volatile PsiJavaCodeReferenceElement[] myCachedRefs;
private volatile PsiClassType[] myCachedTypes;
private final Role myRole;
private final PsiElementFactory myFactory;
@@ -53,26 +52,17 @@ public class LightReferenceListBuilder extends LightElement implements PsiRefere
}
public void addReference(String qualifiedName) {
final PsiJavaCodeReferenceElement ref = myFactory.createReferenceElementByFQClassName(qualifiedName, getResolveScope());
myRefs.add(ref);
myRefs.add(myFactory.createReferenceElementByFQClassName(qualifiedName, getResolveScope()));
}
public void addReference(PsiClassType type) {
final PsiClass resolved = type.resolve();
if (resolved == null) return;
final PsiJavaCodeReferenceElement ref = myFactory.createReferenceElementByType(type);
myRefs.add(ref);
myRefs.add(myFactory.createReferenceElementByType(type));
}
@NotNull
@Override
public PsiJavaCodeReferenceElement[] getReferenceElements() {
PsiJavaCodeReferenceElement[] refs = myCachedRefs;
if (refs == null) {
myCachedRefs = refs = myRefs.toArray(PsiJavaCodeReferenceElement.EMPTY_ARRAY);
}
return refs;
return myRefs.toArray(PsiJavaCodeReferenceElement.EMPTY_ARRAY);
}
@NotNull