diff: cleanup

* do not explicitly pass DEFAULT hint
* do not use FRAME hint - it's better to show modal window, than to show frame window that user cannot see

java/debugger/impl/src/com/intellij/debugger/actions/CompareValueWithClipboardAction.java

@@ -29,6 +29,6 @@ import com.intellij.openapi.project.Project;
 public class CompareValueWithClipboardAction extends BaseValueAction {
   protected void processText(final Project project, final String text, DebuggerTreeNodeImpl node, DebuggerContextImpl debuggerContext) {
     DiffRequest request = DiffRequestFactory.getInstance().createClipboardVsValue(text);
-    DiffManager.getInstance().showDiff(project, request, DiffDialogHints.DEFAULT);
+    DiffManager.getInstance().showDiff(project, request);
   }
 }

platform/diff-impl/src/com/intellij/diff/actions/BaseShowDiffAction.java

@@ -45,7 +45,7 @@ abstract class BaseShowDiffAction extends AnAction implements DumbAware {
     DiffRequest request = getDiffRequest(e);
     if (request == null) return;
 
-    DiffManager.getInstance().showDiff(project, request, DiffDialogHints.DEFAULT);
+    DiffManager.getInstance().showDiff(project, request);
   }
 
   protected abstract boolean isAvailable(@NotNull AnActionEvent e);

platform/vcs-impl/src/com/intellij/openapi/vcs/actions/DiffActionExecutor.java

@@ -167,7 +167,7 @@ public abstract class DiffActionExecutor {
           return;
         }
         if (!requestRef.isNull()) {
-          DiffManager.getInstance().showDiff(myProject, requestRef.get(), DiffDialogHints.FRAME);
+          DiffManager.getInstance().showDiff(myProject, requestRef.get());
         }
       }
     };

platform/vcs-impl/src/com/intellij/openapi/vcs/ex/ShowLineStatusRangeDiffAction.java

@@ -46,7 +46,7 @@ public class ShowLineStatusRangeDiffAction extends BaseLineStatusRangeAction {
 
   @Override
   public void actionPerformed(final AnActionEvent e) {
-    DiffManager.getInstance().showDiff(e.getProject(), createDiffData(), DiffDialogHints.DEFAULT);
+    DiffManager.getInstance().showDiff(e.getProject(), createDiffData());
   }
 
   private DiffRequest createDiffData() {

platform/vcs-impl/src/com/intellij/openapi/vcs/history/VcsHistoryUtil.java

@@ -99,7 +99,7 @@ public class VcsHistoryUtil {
 
     WaitForProgressToShow.runOrInvokeLaterAboveProgress(new Runnable() {
       public void run() {
-        DiffManager.getInstance().showDiff(project, request, DiffDialogHints.FRAME);
+        DiffManager.getInstance().showDiff(project, request);
       }
     }, null, project);
   }

platform/xdebugger-impl/src/com/intellij/xdebugger/impl/ui/tree/actions/XCompareWithClipboardAction.java

@@ -34,7 +34,7 @@ public class XCompareWithClipboardAction extends XFetchValueActionBase {
       @Override
       public void run() {
         DiffRequest request = DiffRequestFactory.getInstance().createClipboardVsValue(value);
-        DiffManager.getInstance().showDiff(project, request, DiffDialogHints.DEFAULT);
+        DiffManager.getInstance().showDiff(project, request);
       }
     });
   }

plugins/svn4idea/src/org/jetbrains/idea/svn/actions/AbstractShowPropertiesDiffAction.java

@@ -178,7 +178,7 @@ public abstract class AbstractShowPropertiesDiffAction extends AnAction implemen
                                                     new PropertyContent(myBeforeContent), new PropertyContent(myAfterContent),
                                                     revisionToString(myBeforeRevisionValue), revisionToString(myAfterRevision));
             }
-            DiffManager.getInstance().showDiff(myProject, diffRequest, DiffDialogHints.DEFAULT);
+            DiffManager.getInstance().showDiff(myProject, diffRequest);
           }
         }
       });

plugins/svn4idea/src/org/jetbrains/idea/svn/diff/FileWithBranchComparer.java

@@ -81,7 +81,7 @@ public class FileWithBranchComparer extends ElementWithBranchComparer {
 
       DiffRequest request = new SimpleDiffRequest(title, content1, content2, title1, title2);
 
-      DiffManager.getInstance().showDiff(myProject, request, DiffDialogHints.DEFAULT);
+      DiffManager.getInstance().showDiff(myProject, request);
     }
   }