MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-05-06 05:10:22 +07:00
Code Issues Packages Projects Releases Wiki Activity

heap pollution:check if possible to make final (IDEA-65920)

Browse Source
This commit is contained in:
anna
2011-03-14 17:00:01 +01:00
parent f95be40d78
commit 63bb62c7fa
5 changed files with 68 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
java/java-impl/src/com/intellij/codeInspection/PossibleHeapPollutionVarargsInspection.java
View File

@@ -19,20 +19,24 @@ import com.intellij.codeInsight.AnnotationUtil;
import com.intellij.codeInsight.daemon.GroupNames;
import com.intellij.codeInsight.daemon.impl.analysis.GenericsHighlightUtil;
import com.intellij.codeInsight.intention.AddAnnotationFix;
import com.intellij.openapi.diagnostic.Logger;
import com.intellij.openapi.project.Project;
import com.intellij.pom.java.LanguageLevel;
import com.intellij.psi.*;
import com.intellij.psi.search.searches.OverridingMethodsSearch;
import com.intellij.psi.search.searches.ReferencesSearch;
import com.intellij.psi.util.PsiTreeUtil;
import com.intellij.psi.util.PsiUtil;
import org.jetbrains.annotations.Nls;
import org.jetbrains.annotations.NotNull;
import sun.util.LocaleServiceProviderPool;
/**
* User: anna
* Date: 1/28/11
*/
public class PossibleHeapPollutionVarargsInspection extends BaseJavaLocalInspectionTool {
public static final Logger LOG = Logger.getInstance("#" + PossibleHeapPollutionVarargsInspection.class.getName());
@Nls
@NotNull
@Override
@@ -70,11 +74,21 @@ public class PossibleHeapPollutionVarargsInspection extends BaseJavaLocalInspect
return new HeapPollutionVisitor() {
@Override
protected void registerProblem(PsiMethod method, PsiIdentifier nameIdentifier) {
holder.registerProblem(nameIdentifier, "Possible heap pollution from parameterized vararg type #loc",
//todo check if can be final or static
method.hasModifierProperty(PsiModifier.FINAL) ||
method.hasModifierProperty(PsiModifier.STATIC) ||
method.isConstructor() ? new AnnotateAsSafeVarargsQuickFix() : null);
final LocalQuickFix quickFix;
if (method.hasModifierProperty(PsiModifier.FINAL) ||
method.hasModifierProperty(PsiModifier.STATIC) ||
method.isConstructor()) {
quickFix = new AnnotateAsSafeVarargsQuickFix();
}
else {
final PsiClass containingClass = method.getContainingClass();
LOG.assertTrue(containingClass != null);
boolean canBeFinal = !method.hasModifierProperty(PsiModifier.ABSTRACT) &&
!containingClass.isInterface() &&
OverridingMethodsSearch.search(method).findFirst() == null;
quickFix = canBeFinal ? new MakeFinalAndAnnotateQuickFix() : null;
}
holder.registerProblem(nameIdentifier, "Possible heap pollution from parameterized vararg type #loc", quickFix);
}
};
}
@@ -102,6 +116,30 @@ public class PossibleHeapPollutionVarargsInspection extends BaseJavaLocalInspect
}
}
private static class MakeFinalAndAnnotateQuickFix implements LocalQuickFix {
@NotNull
@Override
public String getName() {
return "Make final and annotate as @SafeVarargs";
}
@NotNull
@Override
public String getFamilyName() {
return getName();
}
@Override
public void applyFix(@NotNull Project project, @NotNull ProblemDescriptor descriptor) {
final PsiElement psiElement = descriptor.getPsiElement();
if (psiElement instanceof PsiIdentifier) {
final PsiMethod psiMethod = (PsiMethod)psiElement.getParent();
psiMethod.getModifierList().setModifierProperty(PsiModifier.FINAL, true);
new AddAnnotationFix("java.lang.SafeVarargs", psiMethod).applyFix(project, descriptor);
}
}
}
public static abstract class HeapPollutionVisitor extends JavaElementVisitor {
@Override

8
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/safeVarargs/after9.java Normal file
View File

@@ -0,0 +1,8 @@
// "Make final and annotate as @SafeVarargs" "true"
public class Test {
@SafeVarargs
public final <T> void m<caret>ain(T... args) {
}
}

5
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/safeVarargs/before10.java Normal file
View File

@@ -0,0 +1,5 @@
// "Make final and annotate as @SafeVarargs" "false"
public interface Test {
<T> void m<caret>ain(T... args);
}

5
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/safeVarargs/before11.java Normal file
View File

@@ -0,0 +1,5 @@
// "Make final and annotate as @SafeVarargs" "false"
public abstract class Test {
abstract <T> void m<caret>ain(T... args);
}

7
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/safeVarargs/before9.java Normal file
View File

@@ -0,0 +1,7 @@
// "Make final and annotate as @SafeVarargs" "true"
public class Test {
public <T> void m<caret>ain(T... args) {
}
}