mirror of
https://gitflic.ru/project/openide/openide.git
synced 2026-09-27 10:03:11 +07:00
Address review notes
This commit is contained in:
@@ -96,6 +96,7 @@ class BuildTasksImpl extends BuildTasks {
|
||||
buildContext.messages.progress("Building provided modules list for modules $modules")
|
||||
String targetFile = "${targetDirectory.absolutePath}/builtinModules.json"
|
||||
FileUtil.delete(new File(targetFile))
|
||||
// Start the product in headless mode using com.intellij.ide.plugins.BundledPluginsLister.
|
||||
runApplicationStarter("$buildContext.paths.temp/builtinModules", modules, pathsToLicenses, ['listBundledPlugins', targetFile])
|
||||
if (!new File(targetFile).exists()) {
|
||||
buildContext.messages.error("Failed to build provided modules list: $targetFile doesn't exist")
|
||||
@@ -111,6 +112,8 @@ class BuildTasksImpl extends BuildTasks {
|
||||
buildContext.messages.progress("Building searchable options for modules $modulesToIndex")
|
||||
String targetFile = "${targetDirectory.absolutePath}/search/searchableOptions.xml"
|
||||
FileUtil.delete(new File(targetFile))
|
||||
// Start the product in headless mode using com.intellij.ide.ui.search.TraverseUIStarter.
|
||||
// It'll process all UI elements in Settings dialog and build index for them.
|
||||
runApplicationStarter("$buildContext.paths.temp/searchableOptions", modulesToIndex, pathsToLicenses, ['traverseUI', targetFile])
|
||||
if (!new File(targetFile).exists()) {
|
||||
buildContext.messages.error("Failed to build searchable options index: $targetFile doesn't exist")
|
||||
|
||||
+1
-3
@@ -216,9 +216,7 @@ class DistributionJARsBuilder {
|
||||
layoutBuilder.patchModuleOutput(productLayout.searchableOptionsModule, FileUtil.toSystemIndependentName(searchableOptionsDir.absolutePath))
|
||||
}
|
||||
|
||||
if (!buildContext.options.buildStepsToSkip.contains(BuildOptions.PROVIDED_MODULES_LIST_STEP)) {
|
||||
buildTasks.buildProvidedModulesList(new File(buildContext.paths.artifacts), productLayout.mainModules, productLayout.licenseFilesToBuildSearchableOptions)
|
||||
}
|
||||
buildTasks.buildProvidedModulesList(new File(buildContext.paths.artifacts), productLayout.mainModules, productLayout.licenseFilesToBuildSearchableOptions)
|
||||
|
||||
def applicationInfoFile = FileUtil.toSystemIndependentName(patchedApplicationInfo.absolutePath)
|
||||
def applicationInfoDir = "$buildContext.paths.temp/applicationInfo"
|
||||
|
||||
Reference in New Issue
Block a user