MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

dfa: don't store useless primitive != null facts

Browse Source
This commit is contained in:
peter
2015-11-17 17:19:43 +01:00
parent 66b5456707
commit 6293695598
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/DfaMemoryStateImpl.java
+5
View File
@@ -848,6 +848,7 @@ public class DfaMemoryStateImpl implements DfaMemoryState {
}
else { // Not Equals
if (c1Index.equals(c2Index) || areCompatibleConstants(c1Index, c2Index)) return false;
if (isNull(dfaLeft) && isPrimitive(dfaRight) || isNull(dfaRight) && isPrimitive(dfaLeft)) return true;
makeClassesDistinct(c1Index, c2Index);
myCachedDistinctClassPairs = null;
myCachedHash = null;
@@ -856,6 +857,10 @@ public class DfaMemoryStateImpl implements DfaMemoryState {
return true;
}
private static boolean isPrimitive(DfaValue value) {
return value instanceof DfaVariableValue && ((DfaVariableValue)value).getVariableType() instanceof PsiPrimitiveType;
}
private static boolean preserveConstantDistinction(final Object c1, final Object c2) {
return c1 == null && c2 instanceof PsiEnumConstant ||
c2 == null && c1 instanceof PsiEnumConstant;