MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

highlight InitVar and ClassVar with default_factory (PY-28957)

Browse Source
This commit is contained in:
Semyon Proshev
2018-03-20 14:20:25 +03:00
parent 5d1e935acb
commit 610c1b70c3
2 changed files with 34 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/com/jetbrains/python/inspections/PyDataclassInspection.kt
+26 -18
View File
@@ -65,9 +65,12 @@ class PyDataclassInspection : PyInspection() {
val initVars = mutableListOf<PyTargetExpression>()
node.processClassLevelDeclarations { element, _ ->
if (element is PyTargetExpression && !PyTypingTypeProvider.isClassVar(element, myTypeEvalContext)) {
processDefaultFieldValue(element)
processAsInitVar(element, postInit)?.let { initVars.add(it) }
if (element is PyTargetExpression) {
if (!PyTypingTypeProvider.isClassVar(element, myTypeEvalContext)) {
processDefaultFieldValue(element)
processAsInitVar(element, postInit)?.let { initVars.add(it) }
}
processFieldFunctionCall(element)
}
@@ -149,16 +152,12 @@ class PyDataclassInspection : PyInspection() {
if (parseDataclassParameters(cls, myTypeEvalContext) != null) {
cls.processClassLevelDeclarations { element, _ ->
if (element is PyTargetExpression && element.name == node.name) {
val type = myTypeEvalContext.getType(element)
if (element is PyTargetExpression && element.name == node.name && isInitVar(element)) {
registerProblem(node.lastChild,
"'${cls.name}' object could have no attribute '${element.name}' because it is declared as init-only",
ProblemHighlightType.GENERIC_ERROR_OR_WARNING)
if (type is PyClassType && type.classQName == DATACLASSES_INITVAR_TYPE) {
registerProblem(node.lastChild,
"'${cls.name}' object could have no attribute '${element.name}' because it is declared as init-only",
ProblemHighlightType.GENERIC_ERROR_OR_WARNING)
return@processClassLevelDeclarations false
}
return@processClassLevelDeclarations false
}
true
@@ -258,9 +257,7 @@ class PyDataclassInspection : PyInspection() {
}
private fun processAsInitVar(field: PyTargetExpression, postInit: PyFunction?): PyTargetExpression? {
val type = myTypeEvalContext.getType(field)
if (type is PyClassType && type.classQName == DATACLASSES_INITVAR_TYPE) {
if (isInitVar(field)) {
if (postInit == null) {
registerProblem(field,
"Attribute '${field.name}' is useless until '$DUNDER_POST_INIT' is declared",
@@ -274,10 +271,17 @@ class PyDataclassInspection : PyInspection() {
}
private fun processFieldFunctionCall(field: PyTargetExpression) {
val fieldStub = PyDataclassFieldStubImpl.create(field)
if (fieldStub != null && fieldStub.hasDefault() && fieldStub.hasDefaultFactory()) {
val call = field.findAssignedValue() as? PyCallExpression ?: return
val fieldStub = PyDataclassFieldStubImpl.create(field) ?: return
val call = field.findAssignedValue() as? PyCallExpression ?: return
if (PyTypingTypeProvider.isClassVar(field, myTypeEvalContext) || isInitVar(field)) {
if (fieldStub.hasDefaultFactory()) {
registerProblem(call.getKeywordArgument("default_factory"),
"Field cannot have a default factory",
ProblemHighlightType.GENERIC_ERROR)
}
}
else if (fieldStub.hasDefault() && fieldStub.hasDefaultFactory()) {
registerProblem(call.argumentList, "Cannot specify both 'default' and 'default_factory'", ProblemHighlightType.GENERIC_ERROR)
}
}
@@ -318,6 +322,10 @@ class PyDataclassInspection : PyInspection() {
}
}
private fun isInitVar(field: PyTargetExpression): Boolean {
return (myTypeEvalContext.getType(field) as? PyClassType)?.classQName == DATACLASSES_INITVAR_TYPE
}
private fun isNotDataclass(type: PyType?, allowDefinition: Boolean): Boolean {
if (type is PyStructuralType || PyTypeChecker.isUnknown(type, myTypeEvalContext)) return false
if (type is PyUnionType) return type.members.all { isNotDataclass(it, allowDefinition) }
python/testData/inspections/PyDataclassInspection/fieldDefaultAndDefaultFactory.py
+8 -1
View File
@@ -1,7 +1,14 @@
import dataclasses
from typing import ClassVar
@dataclasses.dataclass
class E1:
a: int = dataclasses.field(default=1)
b: int = dataclasses.field(default_factory=int)
c: int = dataclasses.field<error descr="Cannot specify both 'default' and 'default_factory'">(default=1, default_factory=int)</error>
c: int = dataclasses.field<error descr="Cannot specify both 'default' and 'default_factory'">(default=1, default_factory=int)</error>
d: ClassVar[int] = dataclasses.field(default_factory=<error descr="Field cannot have a default factory">int</error>)
e: dataclasses.InitVar[int] = dataclasses.field(default_factory=<error descr="Field cannot have a default factory">int</error>)
def __post_init__(self, e: int):
pass