MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

svn: Refactored CheckinClient - used List<File> instead of Collection<File> for method arguments

Browse Source
This commit is contained in:
Konstantin Kolosovsky
2015-03-24 13:06:22 +03:00
parent a1ebf9c12e
commit 5c0f5bb506
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/svn4idea/src/org/jetbrains/idea/svn/checkin/CheckinClient.java
+2 -2
View File
@@ -20,7 +20,7 @@ import org.jetbrains.annotations.NotNull;
import org.jetbrains.idea.svn.api.SvnClient;
import java.io.File;
import java.util.Collection;
import java.util.List;
/**
* @author Konstantin Kolosovsky.
@@ -28,5 +28,5 @@ import java.util.Collection;
public interface CheckinClient extends SvnClient {
@NotNull
CommitInfo[] commit(@NotNull Collection<File> paths, @NotNull String comment) throws VcsException;
CommitInfo[] commit(@NotNull List<File> paths, @NotNull String comment) throws VcsException;
}
plugins/svn4idea/src/org/jetbrains/idea/svn/checkin/CmdCheckinClient.java
+2 -2
View File
@@ -58,7 +58,7 @@ public class CmdCheckinClient extends BaseSvnClient implements CheckinClient {
@NotNull
@Override
public CommitInfo[] commit(@NotNull Collection<File> paths, @NotNull String message) throws VcsException {
public CommitInfo[] commit(@NotNull List<File> paths, @NotNull String message) throws VcsException {
// if directory renames were used, IDEA reports all files under them as moved, but for svn we can not pass some of them
// to commit command - since not all paths are registered as changes -> so we need to filter these cases, but only if
// there at least some child-parent relationships in passed paths
@@ -102,7 +102,7 @@ public class CmdCheckinClient extends BaseSvnClient implements CheckinClient {
return revision;
}
private Collection<File> filterCommittables(@NotNull Collection<File> committables) throws SvnBindException {
private List<File> filterCommittables(@NotNull List<File> committables) throws SvnBindException {
final Set<String> childrenOfSomebody = ContainerUtil.newHashSet();
new AbstractFilterChildren<File>() {
@Override
plugins/svn4idea/src/org/jetbrains/idea/svn/checkin/SvnKitCheckinClient.java
+2 -2
View File
@@ -32,7 +32,7 @@ import org.tmatesoft.svn.core.wc.SVNCommitClient;
import org.tmatesoft.svn.core.wc.SVNCommitPacket;
import java.io.File;
import java.util.Collection;
import java.util.List;
/**
* @author Konstantin Kolosovsky.
@@ -43,7 +43,7 @@ public class SvnKitCheckinClient extends BaseSvnClient implements CheckinClient
@NotNull
@Override
public CommitInfo[] commit(@NotNull Collection<File> paths, @NotNull String comment) throws VcsException {
public CommitInfo[] commit(@NotNull List<File> paths, @NotNull String comment) throws VcsException {
File[] pathsToCommit = ArrayUtil.toObjectArray(paths, File.class);
boolean keepLocks = myVcs.getSvnConfiguration().isKeepLocks();
SVNCommitPacket[] commitPackets = null;