ensure keywords are added before overridden method variants (IDEA-102228)

This commit is contained in:
peter
2013-03-01 17:13:09 +01:00
parent 1744117d84
commit 5bfb703b14
3 changed files with 4 additions and 6 deletions
@@ -235,6 +235,8 @@ public class JavaCompletionContributor extends CompletionContributor {
}
}
JavaOverrideCompletionContributor.fillCompletionVariants(parameters, result);
addAllClasses(parameters, result, inheritors);
final PsiElement parent = position.getParent();
@@ -38,11 +38,10 @@ import static com.intellij.patterns.PlatformPatterns.psiElement;
/**
* @author peter
*/
public class JavaOverrideCompletionContributor extends CompletionContributor {
public class JavaOverrideCompletionContributor {
static final Key<Boolean> OVERRIDE_ELEMENT = Key.create("OVERRIDE_ELEMENT");
@Override
public void fillCompletionVariants(CompletionParameters parameters, CompletionResultSet _result) {
public static void fillCompletionVariants(CompletionParameters parameters, CompletionResultSet result) {
if (parameters.getCompletionType() != CompletionType.BASIC && parameters.getCompletionType() != CompletionType.SMART) {
return;
}
@@ -53,7 +52,6 @@ public class JavaOverrideCompletionContributor extends CompletionContributor {
andNot(psiElement().afterLeaf(psiElement().inside(PsiModifierList.class))).accepts(position)) {
final PsiClass parent = CompletionUtil.getOriginalElement((PsiClass)position.getParent().getParent().getParent());
if (parent != null) {
CompletionResultSet result = JavaCompletionSorting.addJavaSorting(parameters, _result);
addSuperSignatureElements(parent, true, result);
addSuperSignatureElements(parent, false, result);
}
-2
View File
@@ -301,8 +301,6 @@
order="before javaLegacy, before default"/>
<completion.contributor language="JAVA" implementationClass="com.intellij.codeInsight.completion.JavaMemberNameCompletionContributor" id="javaMemberName"
order="before javaOverride"/>
<completion.contributor language="JAVA" implementationClass="com.intellij.codeInsight.completion.JavaOverrideCompletionContributor" id="javaOverride"
order="before javaLegacy"/>
<completion.contributor language="any" implementationClass="com.intellij.codeInsight.completion.JavaClassNameCompletionContributor" id="javaClassName"
order="last, before default"/>