MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

replace whole attribute as name may affect parsing (e.g. in HTML) (WEB-28553)

Browse Source
This commit is contained in:
Dennis Ushakov
2017-09-01 15:40:11 +03:00
parent c825f02a1a
commit 5ba848bfae
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
xml/xml-psi-impl/src/com/intellij/psi/impl/source/xml/XmlAttributeImpl.java
+8 -3
View File
@@ -310,8 +310,9 @@ public class XmlAttributeImpl extends XmlElementImpl implements XmlAttribute, Hi
public PsiElement setName(@NotNull final String nameText) throws IncorrectOperationException {
final ASTNode name = XmlChildRole.ATTRIBUTE_NAME_FINDER.findChild(this);
final String oldName = name.getText();
final String oldValue = getValue();
final PomModel model = PomManager.getModel(getProject());
final XmlAttribute attribute = XmlElementFactory.getInstance(getProject()).createAttribute(nameText, "", this);
final XmlAttribute attribute = XmlElementFactory.getInstance(getProject()).createAttribute(nameText, oldValue, this);
final ASTNode newName = XmlChildRole.ATTRIBUTE_NAME_FINDER.findChild((ASTNode)attribute);
final XmlAspect aspect = model.getModelAspect(XmlAspect.class);
model.runTransaction(new PomTransactionBase(getParent(), aspect) {
@@ -321,9 +322,13 @@ public class XmlAttributeImpl extends XmlElementImpl implements XmlAttribute, Hi
PsiFile file = getContainingFile();
XmlChangeSet xmlAspectChangeSet = new XmlAspectChangeSetImpl(model, file instanceof XmlFile ? (XmlFile)file : null);
xmlAspectChangeSet.add(new XmlAttributeSetImpl(getParent(), oldName, null));
xmlAspectChangeSet.add(new XmlAttributeSetImpl(getParent(), nameText, getValue()));
xmlAspectChangeSet.add(new XmlAttributeSetImpl(getParent(), nameText, oldValue));
event.registerChangeSet(model.getModelAspect(XmlAspect.class), xmlAspectChangeSet);
CodeEditUtil.replaceChild(XmlAttributeImpl.this, name, newName);
if (oldValue.isEmpty()) {
CodeEditUtil.replaceChild(XmlAttributeImpl.this, name, newName);
} else {
CodeEditUtil.replaceChild(getTreeParent(), XmlAttributeImpl.this, attribute.getNode());
}
return event;
}
});