MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

vcs: Refactored "LocalChangeListImpl" - explicitly use "Set"s to operate with changes

Browse Source
This commit is contained in:
Konstantin Kolosovsky
2016-04-01 17:21:48 +03:00
parent dcf2200773
commit 5b420e1f9c
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/vcs-impl/src/com/intellij/openapi/vcs/changes/LocalChangeListImpl.java
+7 -6
View File
@@ -25,8 +25,8 @@ public class LocalChangeListImpl extends LocalChangeList {
private static final Logger LOG = Logger.getInstance("#com.intellij.openapi.vcs.changes.ChangeList");
private final Project myProject;
private Collection<Change> myChanges = new HashSet<Change>();
private Collection<Change> myReadChangesCache = null;
private Set<Change> myChanges = ContainerUtil.newHashSet();
private Set<Change> myReadChangesCache = null;
private String myId;
@NotNull private String myName;
private String myComment = "";
@@ -53,14 +53,15 @@ public class LocalChangeListImpl extends LocalChangeList {
setNameImpl(origin.myName);
}
public Collection<Change> getChanges() {
@NotNull
public Set<Change> getChanges() {
createReadChangesCache();
return myReadChangesCache;
}
private void createReadChangesCache() {
if (myReadChangesCache == null) {
myReadChangesCache = Collections.unmodifiableCollection(new HashSet<Change>(myChanges));
myReadChangesCache = Collections.unmodifiableSet(ContainerUtil.newHashSet(myChanges));
}
}
@@ -275,7 +276,7 @@ public class LocalChangeListImpl extends LocalChangeList {
copy.myData = myData;
if (myChanges != null) {
copy.myChanges = new HashSet<Change>(myChanges);
copy.myChanges = ContainerUtil.newHashSet(myChanges);
}
if (myChangesBeforeUpdate != null) {
@@ -283,7 +284,7 @@ public class LocalChangeListImpl extends LocalChangeList {
}
if (myReadChangesCache != null) {
copy.myReadChangesCache = new HashSet<Change>(myReadChangesCache);
copy.myReadChangesCache = ContainerUtil.newHashSet(myReadChangesCache);
}
return copy;