MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-182645 Comparator does not return 0: do not report for always failing comparator

Browse Source
This commit is contained in:
Tagir Valeev
2017-11-27 15:52:09 +07:00
parent 5b36191d2c
commit 5adec79f95
2 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/bugs/SuspiciousComparatorCompareInspection.java
+14
View File
@@ -24,6 +24,7 @@ import com.intellij.codeInspection.dataFlow.value.DfaVariableValue;
import com.intellij.psi.*;
import com.intellij.psi.util.PsiTreeUtil;
import com.intellij.psi.util.PsiUtil;
import com.intellij.util.ObjectUtils;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
@@ -96,6 +97,19 @@ public class SuspiciousComparatorCompareInspection extends BaseInspection {
PsiStatement statement = ControlFlowUtils.getOnlyStatementInBlock((PsiCodeBlock)body);
if (statement instanceof PsiReturnStatement && ExpressionUtils.isZero(((PsiReturnStatement)statement).getReturnValue())) return;
}
PsiMethodCallExpression soleCall = ObjectUtils.tryCast(LambdaUtil.extractSingleExpressionFromBody(body), PsiMethodCallExpression.class);
if (soleCall != null) {
PsiMethod method = soleCall.resolveMethod();
if (method != null) {
List<? extends MethodContract> contracts = ControlFlowAnalyzer.getMethodCallContracts(method, soleCall);
if (contracts.size() == 1) {
MethodContract contract = contracts.get(0);
if (contract.isTrivial() && contract.getReturnValue() == MethodContract.ValueConstraint.THROW_EXCEPTION) {
return;
}
}
}
}
PsiParameter[] parameters = parameterList.getParameters();
checkParameterList(parameters, body);
checkReflexivity(parameters, body);
plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/suspicious_comparator_compare/ComparatorIsNotReflexive.java
+6
View File
@@ -27,4 +27,10 @@ class ComparatorIsNotReflexive implements Comparator<Integer> {
if(b1.length != b2.length) return 0; // typo: == was intended
return <warning descr="Comparator does not return 0 for equal elements">b1.length > b2.length ? 1 : -1</warning>;
};
Comparator<String> cmp = (a,b) -> test();
static int test() {
throw new RuntimeException();
}
}