[java-dfa] Preserve accessor as variable having Optional.get as qualifier

IDEA-276924 Incorrect ConstantConditions inspection warning in combination with Optional

GitOrigin-RevId: aba1f4a9f832423626c5e8c64d2777def48df2bc

java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/java/inst/MethodCallInstruction.java

@@ -393,21 +393,14 @@ public class MethodCallInstruction extends ExpressionPushingInstruction {
     DfaValue precalculated = getPrecalculatedReturnValue();
     PsiType type = getResultType();
 
-    SpecialField field = SpecialField.findSpecialField(myTargetMethod);
-    if (field != null) {
-      return field.createValue(factory, qualifierValue);
+    VariableDescriptor descriptor = JavaDfaValueFactory.getAccessedVariableOrGetter(myTargetMethod);
+    if (descriptor instanceof SpecialField || descriptor != null && qualifierValue instanceof DfaVariableValue) {
+      return descriptor.createValue(factory, qualifierValue);
     }
     if (precalculated != null) {
       return precalculated;
     }
 
-    if (getContext() instanceof PsiMethodReferenceExpression && qualifierValue instanceof DfaVariableValue) {
-      VariableDescriptor descriptor = JavaDfaValueFactory.getAccessedVariableOrGetter(myTargetMethod);
-      if (descriptor != null) {
-        return descriptor.createValue(factory, qualifierValue);
-      }
-    }
-
     if (type != null && !(type instanceof PsiPrimitiveType)) {
       Nullability nullability = myReturnNullability;
       Mutability mutable = Mutability.UNKNOWN;

java/java-tests/testData/inspection/dataFlow/fixture/OptionalAsQualifier.java

@@ -0,0 +1,36 @@
+import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
+
+import java.util.Optional;
+
+public class OptionalAsQualifier {
+
+  private static void example(@Nullable Container value) {
+    Optional<Container> optional = Optional.ofNullable(value);
+    if (optional.isPresent() && optional.get().getValue() != null) {
+      foo(optional.get().getValue());
+    }
+
+    if (value != null) {
+      if (value.getValue() != null) {
+        foo(value.getValue());
+      }
+    }
+  }
+
+  private static void foo(@NotNull Object val) {}
+
+  private static class Container {
+    @Nullable private final Object val;
+
+    private Container(@Nullable Object val) {
+      this.val = val;
+    }
+
+    @Nullable
+    public Object getValue() {
+      return val;
+    }
+  }
+
+}

java/java-tests/testSrc/com/intellij/java/codeInspection/DataFlowInspection8Test.java

@@ -260,6 +260,7 @@ public class DataFlowInspection8Test extends DataFlowInspectionTestCase {
   public void testLambdaAfterNullCheck() { doTest(); }
   public void testFlatMapSideEffect() { doTest(); }
   public void testOptionalValueTracking() { doTest(); }
+  public void testOptionalAsQualifier() { doTest(); }
   public void testClearZeroesSize() { doTest(); }
   public void testLambdaInlineReassignReturnWithDeeperEquality() { doTest(); }