MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-91164 Intention should work only on variable name identifier

Browse Source
This commit is contained in:
Max Medvedev
2012-09-11 08:43:03 +04:00
parent bed98927ed
commit 588d68b5eb
1 changed files with 67 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/groovy/src/org/jetbrains/plugins/groovy/intentions/declaration/GrSetStrongTypeIntention.java
+67 -33
View File
@@ -34,6 +34,7 @@ import org.jetbrains.plugins.groovy.lang.psi.api.auxiliary.modifiers.GrModifier;
import org.jetbrains.plugins.groovy.lang.psi.api.auxiliary.modifiers.GrModifierList;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.GrVariable;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.GrVariableDeclaration;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.expressions.GrExpression;
import org.jetbrains.plugins.groovy.lang.psi.expectedTypes.SupertypeConstraint;
import org.jetbrains.plugins.groovy.lang.psi.expectedTypes.TypeConstraint;
import org.jetbrains.plugins.groovy.lang.psi.impl.statements.expressions.TypesUtil;
@@ -47,49 +48,68 @@ import java.util.ArrayList;
*/
public class GrSetStrongTypeIntention extends Intention {
@Override
protected void processIntention(@NotNull PsiElement element, Project project, Editor editor) throws IncorrectOperationException {
if (element instanceof GrVariableDeclaration) {
GrVariable[] variables = ((GrVariableDeclaration)element).getVariables();
ArrayList<TypeConstraint> types = new ArrayList<TypeConstraint>();
for (GrVariable variable : variables) {
if (variable.getInitializerGroovy() != null) {
PsiType type = variable.getInitializerGroovy().getType();
PsiElement parent = element.getParent();
if (!(parent instanceof GrVariable)) return;
PsiElement elementToBuildTemplate;
GrVariable[] variables;
if (parent.getParent() instanceof GrVariableDeclaration) {
variables = ((GrVariableDeclaration)parent.getParent()).getVariables();
elementToBuildTemplate = parent.getParent();
}
else {
variables = new GrVariable[]{((GrVariable)parent)};
elementToBuildTemplate = parent;
}
ArrayList<TypeConstraint> types = new ArrayList<TypeConstraint>();
for (GrVariable variable : variables) {
GrExpression initializer = variable.getInitializerGroovy();
if (initializer != null) {
PsiType type = initializer.getType();
if (type != null) {
types.add(SupertypeConstraint.create(type));
}
}
}
TemplateBuilderImpl builder = new TemplateBuilderImpl(element);
TemplateBuilderImpl builder = new TemplateBuilderImpl(elementToBuildTemplate);
PsiManager manager = element.getManager();
PsiManager manager = element.getManager();
GrModifierList modifierList = ((GrVariableDeclaration)element).getModifierList();
GrModifierList modifierList = ((GrVariable)parent).getModifierList();
PsiElement replaceElement;
if (modifierList.hasModifierProperty(GrModifier.DEF) && modifierList.getModifiers().length == 1) {
replaceElement = PsiUtil.findModifierInList(modifierList, GrModifier.DEF);
PsiElement replaceElement;
if (modifierList != null && modifierList.hasModifierProperty(GrModifier.DEF) && modifierList.getModifiers().length == 1) {
replaceElement = PsiUtil.findModifierInList(modifierList, GrModifier.DEF);
}
else {
if (elementToBuildTemplate instanceof GrVariableDeclaration) {
((GrVariableDeclaration)elementToBuildTemplate).setType(TypesUtil.createType("Abc", element));
}
else {
((GrVariableDeclaration)element).setType(TypesUtil.createType("Abc", element));
replaceElement = ((GrVariableDeclaration)element).getTypeElementGroovy();
((GrVariable)parent).setType(TypesUtil.createType("Abc", element));
}
assert replaceElement != null;
TypeConstraint[] constraints = types.toArray(new TypeConstraint[types.size()]);
ChooseTypeExpression chooseTypeExpression = new ChooseTypeExpression(constraints, manager, replaceElement.getResolveScope());
builder.replaceElement(replaceElement, chooseTypeExpression);
final PsiElement afterPostprocess = CodeInsightUtilBase.forcePsiPostprocessAndRestoreElement(element);
final Template template = builder.buildTemplate();
TextRange range = afterPostprocess.getTextRange();
Document document = editor.getDocument();
document.deleteString(range.getStartOffset(), range.getEndOffset());
TemplateManager templateManager = TemplateManager.getInstance(project);
templateManager.startTemplate(editor, template);
replaceElement = ((GrVariable)parent).getTypeElementGroovy();
}
assert replaceElement != null;
TypeConstraint[] constraints = types.toArray(new TypeConstraint[types.size()]);
ChooseTypeExpression chooseTypeExpression = new ChooseTypeExpression(constraints, manager, replaceElement.getResolveScope());
builder.replaceElement(replaceElement, chooseTypeExpression);
final PsiElement afterPostprocess = CodeInsightUtilBase.forcePsiPostprocessAndRestoreElement(elementToBuildTemplate);
final Template template = builder.buildTemplate();
TextRange range = afterPostprocess.getTextRange();
Document document = editor.getDocument();
document.deleteString(range.getStartOffset(), range.getEndOffset());
TemplateManager templateManager = TemplateManager.getInstance(project);
templateManager.startTemplate(editor, template);
}
@NotNull
@@ -98,10 +118,19 @@ public class GrSetStrongTypeIntention extends Intention {
return new PsiElementPredicate() {
@Override
public boolean satisfiedBy(PsiElement element) {
if (element instanceof GrVariableDeclaration && ((GrVariableDeclaration)element).getTypeElementGroovy() == null) {
GrVariable[] variables = ((GrVariableDeclaration)element).getVariables();
for (GrVariable variable : variables) {
if (variable.getInitializerGroovy() != null) return true;
PsiElement parent = element.getParent();
if (parent instanceof GrVariable &&
((GrVariable)parent).getTypeElementGroovy() == null &&
element == ((GrVariable)parent).getNameIdentifierGroovy()) {
PsiElement pparent = parent.getParent();
if (pparent instanceof GrVariableDeclaration) {
GrVariable[] variables = ((GrVariableDeclaration)pparent).getVariables();
for (GrVariable variable : variables) {
if (isVarDeclaredWithInitializer(variable)) return true;
}
}
else {
return isVarDeclaredWithInitializer((GrVariable)parent);
}
}
@@ -109,4 +138,9 @@ public class GrSetStrongTypeIntention extends Intention {
}
};
}
private static boolean isVarDeclaredWithInitializer(GrVariable variable) {
GrExpression initializer = variable.getInitializerGroovy();
return initializer != null && initializer.getType() != null;
}
}