IDEA-274197: don't suggest change signature if there are no duplicates

GitOrigin-RevId: 86eb8ec79349076bd63c1d7d2f4b97e25377f8fd
This commit is contained in:
Alexandr Suhinin
2021-07-23 12:16:20 +00:00
committed by intellij-monorepo-bot
parent a3710f0175
commit 57bf594709
@@ -88,9 +88,11 @@ class DuplicatesMethodExtractor: InplaceExtractMethodProvider {
val oldMethodCall = PsiTreeUtil.findChildOfType(calls.first(), PsiMethodCallExpression::class.java)
val newMethodCall = PsiTreeUtil.findChildOfType(elementsToReplace.callElements.first(), PsiMethodCallExpression::class.java)
val parametrizedDuplicatesNumber = duplicates.size - exactDuplicates.size
val changeSignature = SignatureSuggesterPreviewDialog(method, elementsToReplace.method, oldMethodCall, newMethodCall, parametrizedDuplicatesNumber).showAndGet()
if (!changeSignature) {
duplicates = exactDuplicates
if (parametrizedDuplicatesNumber > 0){
val changeSignature = SignatureSuggesterPreviewDialog(method, elementsToReplace.method, oldMethodCall, newMethodCall, parametrizedDuplicatesNumber).showAndGet()
if (!changeSignature) {
duplicates = exactDuplicates
}
}
duplicates = confirmDuplicates(project, editor, duplicates)