MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

use iterateAnsectors in PyMissingConstructorInspection. Added test data for PY-3395

Browse Source
This commit is contained in:
Ekaterina Tuzova
2011-04-28 15:05:13 +04:00
parent c9e8dbada4
commit 5747cdabb5
2 changed files with 17 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/com/jetbrains/python/inspections/PyMissingConstructorInspection.java
+11 -12
View File
@@ -47,7 +47,8 @@ public class PyMissingConstructorInspection extends PyInspection {
if (node.isNewStyleClass())
superNames.push(PyNames.SUPER);
addSuperNames(superNames, superClasses, name);
Iterable<PyClassRef> ansectors = node.iterateAncestors();
addSuperNames(superNames, ansectors);
if (!superHasConstructor(node)) return;
PyFunction initMethod = node.findMethodByName(PyNames.INIT, false);
@@ -78,18 +79,16 @@ public class PyMissingConstructorInspection extends PyInspection {
}
}
private static void addSuperNames(Stack<String> st, PsiElement[] superClasses, String name) {
for (PsiElement cl : superClasses) {
if (!name.equals(cl.getText())) {
if (!PyNames.OBJECT.equals(cl.getText()))
st.push(cl.getText());
private static void addSuperNames(Stack<String> st, Iterable<PyClassRef> superClasses) {
for (PyClassRef cl : superClasses) {
if (!PyNames.OBJECT.equals(cl.getClassName()))
st.push(cl.getClassName());
if (cl instanceof PyReferenceExpression) {
PyReferenceExpression ref = (PyReferenceExpression) cl;
final PsiElement result = ref.getReference(PyResolveContext.noProperties()).resolve();
if (result instanceof PyClass)
addSuperNames(st, ((PyClass)result).getSuperClassExpressions(), name);
}
if (cl instanceof PyReferenceExpression) {
PyReferenceExpression ref = (PyReferenceExpression) cl;
final PsiElement result = ref.getReference(PyResolveContext.noProperties()).resolve();
if (result instanceof PyClass)
addSuperNames(st, ((PyClass)result).iterateAncestors());
}
}
}
python/testData/inspections/PyMissingConstructorInspection/test.py
+6 -1
View File
@@ -62,4 +62,9 @@ class B(A):
class C(B):
def <warning descr="Call to constructor of super class is missed">__init__</warning>(self):
print ("Constructor C was called")
print ("Constructor C was called")
#PY-3395
class Over(Over):
def __init__(self):
pass