MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-138792 Better way to avoid formatting when replacing JSON strings in quickfix

Browse Source 
I use CodeStyleManager#performActionWithFormatterDisabled for
this purpose instead of performing modifications on AST nodes.
This commit is contained in:
Mikhail Golubev
2015-04-20 18:57:40 +03:00
parent bd1ab5f421
commit 55dfb5566f
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
json/src/com/intellij/json/codeinsight/JsonStandardComplianceInspection.java
+8 -4
View File
@@ -6,13 +6,13 @@ import com.intellij.codeInspection.ui.MultipleCheckboxOptionsPanel;
import com.intellij.json.JsonBundle;
import com.intellij.json.JsonElementTypes;
import com.intellij.json.psi.*;
import com.intellij.lang.ASTNode;
import com.intellij.openapi.diagnostic.Logger;
import com.intellij.openapi.project.Project;
import com.intellij.psi.PsiComment;
import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiElementVisitor;
import com.intellij.psi.PsiWhiteSpace;
import com.intellij.psi.codeStyle.CodeStyleManager;
import com.intellij.psi.tree.IElementType;
import com.intellij.psi.util.PsiTreeUtil;
import org.jetbrains.annotations.NotNull;
@@ -145,9 +145,13 @@ public class JsonStandardComplianceInspection extends LocalInspectionTool {
if (element instanceof JsonStringLiteral && rawText.startsWith("'")) {
content = escapeSingleQuotedStringContent(content);
}
// TODO: find out better way to replace element and skip reformatting step afterwards
final ASTNode replacement = new JsonElementGenerator(project).createValue("\"" + content + "\"").getNode();
element.getParent().getNode().replaceChild(element.getNode(), replacement);
final PsiElement replacement = new JsonElementGenerator(project).createValue("\"" + content + "\"");
CodeStyleManager.getInstance(project).performActionWithFormatterDisabled(new Runnable() {
@Override
public void run() {
element.replace(replacement);
}
});
}
else if (element != null) {
LOG.error("Quick fix was applied to unexpected element", rawText, element.getParent().getText());