MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-10-06 06:21:16 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-313962: do not update files again if it is not required

Browse Source 
GitOrigin-RevId: 790c31e0e1de91c4b0874dad39c64b2349b411c7
This commit is contained in:
Dmitry Kichinsky
2023-03-01 17:10:13 +00:00
committed by intellij-monorepo-bot
parent 2e0d08ce29
commit 5397ce744e
1 changed files with 23 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/maven/src/main/java/org/jetbrains/idea/maven/project/MavenProjectsTree.java
+23 -10
View File
@@ -549,14 +549,33 @@ public final class MavenProjectsTree {
return;
}
var existingMavenProject = tree.findProject(mavenProjectFile);
boolean isNew = existingMavenProject == null;
var mavenProject = isNew ? new MavenProject(mavenProjectFile) : existingMavenProject;
MavenProjectTimestamp timestamp = tree.calculateTimestamp(mavenProject, explicitProfiles, generalSettings);
boolean timeStampChanged = !timestamp.equals(tree.myTimestamps.get(mavenProject));
updateHistory.putIfAbsent(mavenProjectFile, new CopyOnWriteArrayList<>());
var fileHistory = updateHistory.get(mavenProjectFile);
for (var settings : fileHistory) {
if (settings.recursive() && settings.forceReading()) {
// we already updated this file with recursion and forced reading, no need to update it again
MavenLog.LOG.debug("Has already been updated: " + mavenProjectFile);
if (!timeStampChanged) {
if (!fileHistory.isEmpty() && !recursive && !forceReading) {
// we already updated this file with the same or stricter settings
MavenLog.LOG.debug("Has already been updated (same/stricter): " + mavenProjectFile);
return;
}
for (var settings : fileHistory) {
if (settings.recursive() && settings.forceReading()) {
// we already updated this file with recursion and forced reading
MavenLog.LOG.debug("Has already been updated (recursive, forced): " + mavenProjectFile);
return;
}
// we already updated this file with the same settings
if (settings.recursive() == recursive && settings.forceReading() == forceReading) {
MavenLog.LOG.debug("Has already been updated (same): " + mavenProjectFile);
return;
}
}
}
fileHistory.add(new UpdateSettings(recursive, forceReading));
@@ -564,10 +583,6 @@ public final class MavenProjectsTree {
process.setText(MavenProjectBundle.message("maven.reading.pom", mavenProjectFile.getPath()));
process.setText2("");
var existingMavenProject = tree.findProject(mavenProjectFile);
boolean isNew = existingMavenProject == null;
var mavenProject = isNew ? new MavenProject(mavenProjectFile) : existingMavenProject;
List<MavenProject> prevModules = tree.getModules(mavenProject);
Set<MavenProject> prevInheritors = new HashSet<>();
@@ -575,8 +590,6 @@ public final class MavenProjectsTree {
prevInheritors.addAll(tree.findInheritors(mavenProject));
}
MavenProjectTimestamp timestamp = tree.calculateTimestamp(mavenProject, explicitProfiles, generalSettings);
boolean timeStampChanged = !timestamp.equals(tree.myTimestamps.get(mavenProject));
boolean readProject = forceReading || timeStampChanged;
if (readProject) {