MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IJPL-930 Do not cache getIn result for ModuleExportedDependenciesGraph

Browse Source 
GitOrigin-RevId: 029536e5bb8206a47d9018bf3c8af96f5b8bb7b8
This commit is contained in:
Ilya Korennoy
2026-02-14 08:22:32 +00:00
committed by intellij-monorepo-bot
parent fca8fb36c8
commit 530092ee14
1 changed files with 11 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/projectModel-impl/src/com/intellij/workspaceModel/ide/impl/legacyBridge/module/ModuleExportedDependenciesGraph.kt
+11 -15
View File
@@ -14,7 +14,6 @@ import com.intellij.platform.workspace.storage.EntityStorage
import com.intellij.platform.workspace.storage.VersionedEntityStorage
import com.intellij.util.graph.Graph
import org.jetbrains.annotations.ApiStatus
import java.util.concurrent.ConcurrentHashMap
/**
* [Graph.getIn] returns [ModuleEntity] which depend on the given module taking into account exported dependencies.
@@ -42,7 +41,6 @@ class ModuleExportedDependenciesGraph(project: Project) {
fun buildGraph(storage: EntityStorage): Graph<ModuleEntity> {
return object : Graph<ModuleEntity> {
private val directDependents: Map<ModuleId, List<DependencyEdge>>
private val cache = ConcurrentHashMap<ModuleEntity, Set<ModuleEntity>>()
init {
val dependentsMap = HashMap<ModuleId, MutableList<DependencyEdge>>()
@@ -65,23 +63,21 @@ class ModuleExportedDependenciesGraph(project: Project) {
}
override fun getIn(node: ModuleEntity): Iterator<ModuleEntity> {
return cache.computeIfAbsent(node) {
val result = HashSet<ModuleEntity>()
val queue = ArrayDeque<ModuleEntity>()
queue.add(node)
val result = HashSet<ModuleEntity>()
val queue = ArrayDeque<ModuleEntity>()
queue.add(node)
while (queue.isNotEmpty()) {
val current = queue.removeFirst()
val edges = directDependents[current.symbolicId] ?: emptyList()
while (queue.isNotEmpty()) {
val current = queue.removeFirst()
val edges = directDependents[current.symbolicId] ?: emptyList()
for (edge in edges) {
if (result.add(edge.dependent) && edge.exported) {
queue.add(edge.dependent)
}
for (edge in edges) {
if (result.add(edge.dependent) && edge.exported) {
queue.add(edge.dependent)
}
}
result
}.iterator()
}
return result.iterator()
}
override fun getOut(node: ModuleEntity): Iterator<ModuleEntity> {