MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-04-20 13:31:28 +07:00
Code Issues Packages Projects Releases Wiki Activity

CollapseIntoLoopAction: disable when expression is written

Browse Source 
GitOrigin-RevId: aa405149d65d0e669bc18f87359f486981c1c899
This commit is contained in:
Tagir Valeev
2020-06-16 17:12:11 +07:00
committed by intellij-monorepo-bot
parent 0dcc904eb3
commit 51cd561f79
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
java/java-impl/src/com/intellij/codeInsight/intention/impl/CollapseIntoLoopAction.java
View File

@@ -229,6 +229,7 @@ public class CollapseIntoLoopAction implements IntentionAction {
if (!(leftDiff instanceof PsiExpression) || !(rightDiff instanceof PsiExpression)) return false;
curIterationExpression = (PsiExpression)rightDiff;
firstIterationExpression = (PsiExpression)leftDiff;
if (PsiUtil.isAccessedForWriting(curIterationExpression)) return false;
PsiType curType = curIterationExpression.getType();
PsiType firstType = firstIterationExpression.getType();
if (curType == null || !curType.equals(firstType)) return false;

9
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/collapseIntoLoop/beforeWriting.java Normal file
View File

@@ -0,0 +1,9 @@
// "Collapse into loop" "false"
class X {
void test() {
int x, y, z;
<selection>x = 1;
y = 1;
z = 1;</selection>
}
}