MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-13 21:55:01 +07:00
Code Issues Packages Projects Releases Wiki Activity

ensure left expression is processed before right in assignments (IDEA-140772)

Browse Source
This commit is contained in:
Anna Kozlova
2015-07-03 14:57:13 +03:00
parent ff8fd97028
commit 51404269ff
3 changed files with 19 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-psi-impl/src/com/intellij/psi/controlFlow/ControlFlowAnalyzer.java
+8 -5
View File
@@ -1262,13 +1262,12 @@ class ControlFlowAnalyzer extends JavaElementVisitor {
myStartStatementStack.pushStatement(expression.getRExpression() == null ? expression : expression.getRExpression(), false);
myEndStatementStack.pushStatement(expression.getRExpression() == null ? expression : expression.getRExpression(), false);
PsiExpression rExpr = expression.getRExpression();
if (rExpr != null) {
rExpr.accept(this);
}
PsiExpression lExpr = PsiUtil.skipParenthesizedExprDown(expression.getLExpression());
if (lExpr instanceof PsiReferenceExpression) {
PsiExpression rExpr = expression.getRExpression();
if (rExpr != null) {
rExpr.accept(this);
}
final PsiReferenceExpression referenceExpression = (PsiReferenceExpression)lExpr;
PsiExpression qualifierExpression = referenceExpression.getQualifierExpression();
PsiVariable variable = getUsedVariable(referenceExpression);
@@ -1293,6 +1292,10 @@ class ControlFlowAnalyzer extends JavaElementVisitor {
}
else if (lExpr != null) {
lExpr.accept(this);
PsiExpression rExpr = expression.getRExpression();
if (rExpr != null) {
rExpr.accept(this);
}
}
myStartStatementStack.popStatement();
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/advHighlighting6/InitializedBeforeUsed.java
+7
View File
@@ -0,0 +1,7 @@
class Test {
public static void main(String[] args) {
int i;
int[] iA = {10,20};
iA[<error descr="Variable 'i' might not have been initialized">i</error>] = i = 30;
}
}
java/java-tests/testSrc/com/intellij/codeInsight/daemon/LightAdvHighlightingJdk6Test.java
+4
View File
@@ -63,4 +63,8 @@ public class LightAdvHighlightingJdk6Test extends LightDaemonAnalyzerTestCase {
public void testAgentPremain() {
doTest(false, false);
}
public void testInitializedBeforeUsed() throws Exception {
doTest(false, false);
}
}