MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-05-06 05:10:22 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-225861 Detect a case related to String transformation where result can be predicted before transformation

Browse Source 
GitOrigin-RevId: 3448b86219bebc4914cccae89e7e46db67d81128
This commit is contained in:
Tagir Valeev
2019-10-31 16:03:57 +07:00
committed by intellij-monorepo-bot
parent 7d310b15ed
commit 50b74c2848
3 changed files with 30 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantStringOperation/afterToLowerCaseIsEmpty.java Normal file
View File

@@ -0,0 +1,8 @@
// "Remove redundant 'toLowerCase()' call" "true"
class X {
void test(String string) {
if (string.isEmpty()) {
System.out.println("Empty");
}
}
}

8
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantStringOperation/beforeToLowerCaseIsEmpty.java Normal file
View File

@@ -0,0 +1,8 @@
// "Remove redundant 'toLowerCase()' call" "true"
class X {
void test(String string) {
if (string.to<caret>LowerCase().isEmpty()) {
System.out.println("Empty");
}
}
}

17
plugins/InspectionGadgets/src/com/siyeh/ig/redundancy/RedundantStringOperationInspection.java
View File

@@ -27,8 +27,7 @@ import java.util.Objects;
import static com.intellij.psi.CommonClassNames.JAVA_LANG_STRING;
import static com.intellij.util.ObjectUtils.tryCast;
import static com.siyeh.InspectionGadgetsBundle.BUNDLE;
import static com.siyeh.ig.callMatcher.CallMatcher.anyOf;
import static com.siyeh.ig.callMatcher.CallMatcher.instanceCall;
import static com.siyeh.ig.callMatcher.CallMatcher.*;
public class RedundantStringOperationInspection extends AbstractBaseJavaLocalInspectionTool implements CleanupLocalInspectionTool {
enum FixType {
@@ -49,6 +48,8 @@ public class RedundantStringOperationInspection extends AbstractBaseJavaLocalIns
private static final CallMatcher METHOD_WITH_REDUNDANT_ZERO_AS_SECOND_PARAMETER =
instanceCall(JAVA_LANG_STRING, "indexOf", "startsWith").parameterCount(2);
private static final CallMatcher STRING_LAST_INDEX_OF = instanceCall(JAVA_LANG_STRING, "lastIndexOf").parameterCount(2);
private static final CallMatcher STRING_IS_EMPTY = instanceCall(JAVA_LANG_STRING, "isEmpty").parameterCount(0);
private static final CallMatcher CASE_CHANGE = exactInstanceCall(JAVA_LANG_STRING, "toUpperCase", "toLowerCase");
@Nls
@NotNull
@@ -77,7 +78,8 @@ public class RedundantStringOperationInspection extends AbstractBaseJavaLocalIns
.register(STRING_INTERN, this::getInternProblem)
.register(PRINTSTREAM_PRINTLN, call -> getRedundantArgumentProblem(getSingleEmptyStringArgument(call)))
.register(METHOD_WITH_REDUNDANT_ZERO_AS_SECOND_PARAMETER, this::getRedundantZeroAsSecondParameterProblem)
.register(STRING_LAST_INDEX_OF, this::getLastIndexOfProblem);
.register(STRING_LAST_INDEX_OF, this::getLastIndexOfProblem)
.register(STRING_IS_EMPTY, this::getRedundantCaseChangeProblem);
private final InspectionManager myManager;
private final ProblemsHolder myHolder;
private final boolean myIsOnTheFly;
@@ -133,6 +135,15 @@ public class RedundantStringOperationInspection extends AbstractBaseJavaLocalIns
return null;
}
@Nullable
private ProblemDescriptor getRedundantCaseChangeProblem(PsiMethodCallExpression call) {
PsiMethodCallExpression qualifierCall = MethodCallUtils.getQualifierMethodCall(call);
if (CASE_CHANGE.test(qualifierCall)) {
return getProblem(qualifierCall, "inspection.redundant.string.call.message");
}
return null;
}
@Nullable
private ProblemDescriptor getAppendProblem(PsiMethodCallExpression call) {
return getSingleEmptyStringArgument(call) != null ? getProblem(call, "inspection.redundant.string.call.message") : null;