MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

Java: Moved text message to the resource bundle in the inspection "Non-accessible type is exposed" (IDEA-162768)

Browse Source
This commit is contained in:
Pavel Dolgov
2016-11-11 18:48:45 +03:00
parent 2dbf8ea062
commit 5028edd38c
2 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-analysis-impl/src/com/intellij/codeInspection/java19modules/Java9NonAccessibleTypeExposedInspection.java
+8 -4
View File
@@ -17,6 +17,7 @@ package com.intellij.codeInspection.java19modules;
import com.intellij.codeInsight.daemon.impl.analysis.JavaModuleGraphUtil;
import com.intellij.codeInspection.BaseJavaLocalInspectionTool;
import com.intellij.codeInspection.InspectionsBundle;
import com.intellij.codeInspection.ProblemsHolder;
import com.intellij.openapi.module.Module;
import com.intellij.openapi.roots.ModuleFileIndex;
@@ -66,7 +67,6 @@ public class Java9NonAccessibleTypeExposedInspection extends BaseJavaLocalInspec
}
private static class NonAccessibleTypeExposedVisitor extends JavaElementVisitor {
public static final String CLASS_IS_NOT_EXPORTED = "The class is not exported from the module";
private final ProblemsHolder myHolder;
private final ModuleFileIndex myModuleFileIndex;
private final Set<String> myExportedPackageNames;
@@ -118,12 +118,12 @@ public class Java9NonAccessibleTypeExposedInspection extends BaseJavaLocalInspec
if (isInModuleSource(annotationClass) && !isModulePublicApi(annotationClass)) {
PsiAnnotationOwner owner = annotation.getOwner();
if (isModulePublicApi(owner)) {
myHolder.registerProblem(referenceElement, CLASS_IS_NOT_EXPORTED);
registerProblem(referenceElement);
}
if (owner instanceof PsiParameter) {
PsiElement parent = ((PsiParameter)owner).getParent();
if (parent instanceof PsiMember && isModulePublicApi((PsiMember)parent)) {
myHolder.registerProblem(referenceElement, CLASS_IS_NOT_EXPORTED);
registerProblem(referenceElement);
}
}
}
@@ -161,7 +161,7 @@ public class Java9NonAccessibleTypeExposedInspection extends BaseJavaLocalInspec
private void checkType(@Nullable PsiClass psiClass, @NotNull PsiElement typeElement) {
if (psiClass != null && !(psiClass instanceof PsiTypeParameter) && isInModuleSource(psiClass) && !isModulePublicApi(psiClass)) {
myHolder.registerProblem(typeElement, CLASS_IS_NOT_EXPORTED);
registerProblem(typeElement);
}
}
@@ -250,5 +250,9 @@ public class Java9NonAccessibleTypeExposedInspection extends BaseJavaLocalInspec
}
return false;
}
private void registerProblem(PsiElement element) {
myHolder.registerProblem(element, InspectionsBundle.message("inspection.non.accessible.type.exposed.name"));
}
}
}
platform/platform-resources-en/src/messages/InspectionsBundle.properties
+2
View File
@@ -466,6 +466,8 @@ inspection.compiler.javac.quirks.anno.array.comma.fix=Remove trailing comma
inspection.compiler.javac.quirks.qualifier.type.args.problem=Generics in qualifier reference may cause compilation error in some Javac versions (e.g. JDK 5 and JDK 6).
inspection.compiler.javac.quirks.qualifier.type.args.fix=Remove generic parameter
inspection.non.accessible.type.exposed.name=The class is not exported from the module
inspection.root.node.title=Inspections
# inspection tools list actions: