MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

Java inspection: don't check for non-physical elements in "Make Type Generic" inspection, it's already done in the inspection infrastructure (IDEA-157727)

Browse Source
This commit is contained in:
Pavel Dolgov
2016-07-04 16:54:03 +03:00
parent de9d458275
commit 4fac0ed9aa
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-analysis-impl/src/com/intellij/codeInspection/miscGenerics/MakeTypeGenericInspection.java
+7 -5
View File
@@ -38,15 +38,17 @@ public class MakeTypeGenericInspection extends BaseJavaBatchLocalInspectionTool
public void visitVariable(PsiVariable variable) {
super.visitVariable(variable);
final PsiTypeElement variableTypeElement = variable.getTypeElement();
if (variableTypeElement != null && variableTypeElement.isPhysical()) {
if (variableTypeElement != null) {
final PsiType type = getSuggestedType(variable);
if (type != null) {
final String typeText = type.getCanonicalText();
final String message = InspectionsBundle.message("inspection.raw.variable.type.make.generic.text", variable.getName(), typeText);
final PsiElement beforeInitializer = PsiTreeUtil.skipSiblingsBackward(variable.getInitializer(), PsiWhiteSpace.class, PsiComment.class);
final PsiElement endElement = beforeInitializer != null && beforeInitializer.isPhysical() ? beforeInitializer : variableTypeElement;
final String message =
InspectionsBundle.message("inspection.raw.variable.type.make.generic.text", variable.getName(), typeText);
final PsiElement beforeInitializer =
PsiTreeUtil.skipSiblingsBackward(variable.getInitializer(), PsiWhiteSpace.class, PsiComment.class);
final ProblemDescriptor descriptor =
holder.getManager().createProblemDescriptor(variableTypeElement, endElement,
holder.getManager().createProblemDescriptor(variableTypeElement,
beforeInitializer != null ? beforeInitializer : variableTypeElement,
message, ProblemHighlightType.GENERIC_ERROR_OR_WARNING,
isOnTheFly, new MyLocalQuickFix(message));
holder.registerProblem(descriptor);