MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-04-19 13:02:30 +07:00
Code Issues Packages Projects Releases Wiki Activity

[debugger] fixed some warnings

Browse Source 
GitOrigin-RevId: 6688154d4f8faa21e3b2018c4f0fe0a3167e7ec8
This commit is contained in:
Egor Ushakov
2024-04-08 14:46:47 +02:00
committed by intellij-monorepo-bot
parent 5a61fd5a56
commit 4f4f2b6ff7
3 changed files with 13 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
platform/xdebugger-impl/src/com/intellij/xdebugger/impl/XDebugSessionImpl.java
View File

@@ -1,4 +1,4 @@
// Copyright 2000-2023 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
// Copyright 2000-2024 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package com.intellij.xdebugger.impl;
import com.intellij.execution.configurations.RunConfiguration;
@@ -31,6 +31,7 @@ import com.intellij.openapi.util.Pair;
import com.intellij.ui.AppUIUtil;
import com.intellij.util.EventDispatcher;
import com.intellij.util.SmartList;
import com.intellij.util.concurrency.annotations.RequiresReadLock;
import com.intellij.util.messages.MessageBusConnection;
import com.intellij.util.ui.UIUtil;
import com.intellij.xdebugger.*;
@@ -333,9 +334,9 @@ public final class XDebugSessionImpl implements XDebugSession {
rebuildViews();
}
@RequiresReadLock
@Override
public void initBreakpoints() {
ApplicationManager.getApplication().assertReadAccessAllowed();
LOG.assertTrue(!breakpointsInitialized);
breakpointsInitialized = true;
@@ -499,8 +500,8 @@ public final class XDebugSessionImpl implements XDebugSession {
}
}
@RequiresReadLock
public boolean isBreakpointActive(@NotNull XBreakpoint<?> b) {
ApplicationManager.getApplication().assertReadAccessAllowed();
return !areBreakpointsMuted() && b.isEnabled() && !isInactiveSlaveBreakpoint(b) && !((XBreakpointBase<?, ?, ?>)b).isDisposed();
}
@@ -524,9 +525,9 @@ public final class XDebugSessionImpl implements XDebugSession {
myDispatcher.removeListener(listener);
}
@RequiresReadLock
@Override
public void setBreakpointMuted(boolean muted) {
ApplicationManager.getApplication().assertReadAccessAllowed();
if (areBreakpointsMuted() == muted) return;
mySessionData.setBreakpointsMuted(muted);
if (!myBreakpointsDisabled) {
@@ -599,8 +600,8 @@ public final class XDebugSessionImpl implements XDebugSession {
myDebugProcess.startPausing();
}
@RequiresReadLock
private void processAllBreakpoints(final boolean register, final boolean temporary) {
ApplicationManager.getApplication().assertReadAccessAllowed();
for (XBreakpointHandler<?> handler : myDebugProcess.getBreakpointHandlers()) {
processBreakpoints(handler, register, temporary);
}

4
platform/xdebugger-impl/src/com/intellij/xdebugger/impl/breakpoints/BreakpointsStatisticsCollector.kt
View File

@@ -1,4 +1,4 @@
// Copyright 2000-2021 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
// Copyright 2000-2024 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package com.intellij.xdebugger.impl.breakpoints
import com.intellij.internal.statistic.beans.MetricEvent
@@ -113,7 +113,7 @@ class BreakpointsUtilValidator : CustomValidationRule() {
override fun doValidate(data: String, context: EventContext): ValidationResultType {
if ("custom" == data) return ValidationResultType.ACCEPTED
for (breakpoint in XBreakpointType.EXTENSION_POINT_NAME.extensions) {
for (breakpoint in XBreakpointType.EXTENSION_POINT_NAME.extensionList) {
if (StringUtil.equals(breakpoint.id, data)) {
val info = getPluginInfo(breakpoint.javaClass)
return if (info.isDevelopedByJetBrains()) ValidationResultType.ACCEPTED else ValidationResultType.REJECTED

12
platform/xdebugger-impl/src/com/intellij/xdebugger/impl/ui/attach/dialog/extensions/XAttachToProcessViewProvider.kt
View File

@@ -1,4 +1,4 @@
// Copyright 2000-2023 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
// Copyright 2000-2024 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package com.intellij.xdebugger.impl.ui.attach.dialog.extensions
import com.intellij.openapi.extensions.ExtensionPointName
@@ -23,12 +23,10 @@ interface XAttachToProcessViewProvider {
columnsLayout: AttachDialogColumnsLayout,
attachDebuggerProviders: List<XAttachDebuggerProvider>,
attachHostProviders: List<XAttachHostProvider<out XAttachHost>> = emptyList()
) = EP.extensions.mapNotNull {
if (it.isApplicable(attachHostProviders))
it.getProcessView(project, state, columnsLayout, attachDebuggerProviders, attachHostProviders)
else
null
}
) = EP.extensionList.asSequence()
.filter { it.isApplicable(attachHostProviders) }
.map { it.getProcessView(project, state, columnsLayout, attachDebuggerProviders, attachHostProviders) }
.toList()
}
fun isApplicable(attachHostProviders: List<XAttachHostProvider<out XAttachHost>>) = true