MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

fix flaky test by initializing a structure on pane creation

Browse Source
This commit is contained in:
Sergey Malenkov
2017-11-02 22:44:18 +03:00
parent 12d78fa683
commit 4f3975db60
2 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-impl/src/com/intellij/ide/projectView/impl/PackageViewPane.java
+1 -1
View File
@@ -61,7 +61,7 @@ import java.util.*;
import static com.intellij.openapi.application.Experiments.isFeatureEnabled;
public final class PackageViewPane extends AbstractProjectViewPSIPane {
public class PackageViewPane extends AbstractProjectViewPSIPane {
@NonNls public static final String ID = "PackagesPane";
private final MyDeletePSIElementProvider myDeletePSIElementProvider = new MyDeletePSIElementProvider();
java/java-tests/testSrc/com/intellij/projectView/PackagesTreeStructureTest.java
+9 -4
View File
@@ -16,8 +16,8 @@
package com.intellij.projectView;
import com.intellij.ide.projectView.ProjectView;
import com.intellij.ide.projectView.impl.AbstractProjectTreeStructure;
import com.intellij.ide.projectView.impl.PackageViewPane;
import com.intellij.ide.projectView.impl.ProjectAbstractTreeStructureBase;
import com.intellij.ide.projectView.impl.ProjectViewImpl;
import com.intellij.lang.properties.projectView.ResourceBundleGrouper;
import com.intellij.openapi.application.ApplicationManager;
@@ -213,10 +213,15 @@ public class PackagesTreeStructureTest extends TestSourceBasedTestCase {
projectView.setAbbreviatePackageNames(abbreviatePackageNames, PackageViewPane.ID);
projectView.setHideEmptyPackages(true, PackageViewPane.ID);
PackageViewPane packageViewPane = new PackageViewPane(myProject);
PackageViewPane packageViewPane = new PackageViewPane(myProject) {
@Override
protected ProjectAbstractTreeStructureBase createStructure() {
ProjectAbstractTreeStructureBase structure = super.createStructure();
structure.setProviders(new ResourceBundleGrouper(myProject));
return structure;
}
};
packageViewPane.createComponent();
((AbstractProjectTreeStructure) packageViewPane.getTreeStructure()).setProviders(new ResourceBundleGrouper(myProject));
packageViewPane.updateFromRoot(true);
JTree tree = packageViewPane.getTree();
PlatformTestUtil.waitForPromise(TreeUtil.promiseExpand(tree, levels - 1)); // -1 because root node is not visible
PlatformTestUtil.assertTreeEqual(tree, expected);