MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

testFramework [platform]: Fail test when a fixture throws an exception.

Browse Source 
Currently, exceptions thrown by fixture teardowns are ignored as they are thrown in background scope.

We collect them and report them

GitOrigin-RevId: 8cfdff26574e10adfc954b02f53c3fb032cfaf0d
This commit is contained in:
Ilya.Kazakevich
2026-02-12 22:37:11 +00:00
committed by intellij-monorepo-bot
parent 6fd48ce650
commit 4c728ae18e
1 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/testFramework/junit5/src/fixture/TestFixtureExtension.kt
+20 -1
View File
@@ -5,6 +5,11 @@ import com.intellij.platform.eel.EelApi
import com.intellij.platform.util.coroutines.childScope
import com.intellij.testFramework.TestLoggerFactory
import com.intellij.testFramework.junit5.fixture.EelForFixturesProvider.Companion.getEelForParametrizedTestProvider
import com.intellij.testFramework.junit5.impl.TypedStoreKey
import com.intellij.testFramework.junit5.impl.TypedStoreKey.Companion.get
import com.intellij.testFramework.junit5.impl.TypedStoreKey.Companion.remove
import com.intellij.testFramework.junit5.impl.TypedStoreKey.Companion.set
import kotlinx.coroutines.CoroutineExceptionHandler
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Deferred
import kotlinx.coroutines.DelicateCoroutinesApi
@@ -36,6 +41,9 @@ internal class TestFixtureExtension : BeforeAllCallback,
AfterEachCallback,
AfterAllCallback,
InvocationInterceptor {
private companion object {
val exceptionsKey = TypedStoreKey.createKey<Throwable>()
}
override fun beforeAll(context: ExtensionContext) {
before(context, static = true)
@@ -88,8 +96,13 @@ internal class TestFixtureExtension : BeforeAllCallback,
TestLoggerFactory.onFixturesInitializationStarted(static)
val exceptionHandler = CoroutineExceptionHandler { _, exception ->
context[exceptionsKey] = exception
throw exception
}
@OptIn(DelicateCoroutinesApi::class)
val testScope = GlobalScope.childScope(context.displayName)
val testScope = GlobalScope.childScope(context.displayName, exceptionHandler)
val pendingFixtures = ArrayList<Deferred<*>>()
val classToTestInstance = collectTestInstances(context)
@@ -125,6 +138,12 @@ internal class TestFixtureExtension : BeforeAllCallback,
after(context, static = false)
}
after(context, static = true)
// Throw unprocessed exceptions thrown by fixtures to break the test
val exception = context[exceptionsKey]
context.remove(exceptionsKey)
if (exception != null) {
throw exception
}
}
private fun after(context: ExtensionContext, static: Boolean) {