MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-04-20 13:31:28 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-154891 IDEA adds unnecessary space/colon on switch case autocompletion

Browse Source
This commit is contained in:
peter
2016-04-29 20:52:29 +02:00
parent 6663489749
commit 48b941daa8
4 changed files with 24 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/java-impl/src/com/intellij/codeInsight/lookup/VariableLookupItem.java
View File

@@ -203,7 +203,7 @@ public class VariableLookupItem extends LookupItem<PsiVariable> implements Typed
TailType.COMMA.processTail(context.getEditor(), context.getTailOffset());
AutoPopupController.getInstance(context.getProject()).autoPopupParameterInfo(context.getEditor(), null);
}
else if (completionChar == ':') {
else if (completionChar == ':' && getAttribute(LookupItem.TAIL_TYPE_ATTR) != TailType.UNKNOWN) {
context.setAddCompletionChar(false);
TailType.COND_EXPR_COLON.processTail(context.getEditor(), context.getTailOffset());
}

11
java/java-tests/testData/codeInsight/completion/normal/SwitchValueFinishWithColon.java Normal file
View File

@@ -0,0 +1,11 @@
class Foo {
void foo(Constants c) {
switch (c) {
case B<caret>
}
}
}
enum Constants {
BAR0, BAR1;
}

11
java/java-tests/testData/codeInsight/completion/normal/SwitchValueFinishWithColon_after.java Normal file
View File

@@ -0,0 +1,11 @@
class Foo {
void foo(Constants c) {
switch (c) {
case BAR0:<caret>
}
}
}
enum Constants {
BAR0, BAR1;
}

1
java/java-tests/testSrc/com/intellij/codeInsight/completion/NormalCompletionTest.groovy
View File

@@ -1045,6 +1045,7 @@ public class ListUtils {
public void testNoFieldsInImplements() throws Throwable { doTest() }
public void testSwitchConstantsFromReferencedClass() throws Throwable { doTest('\n') }
public void testSwitchValueFinishWithColon() throws Throwable { doTest(':') }
public void testUnfinishedMethodTypeParameter() throws Throwable {
configure()