MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

[vfs] stop OTel monitoring on .dispose()

Browse Source 
GitOrigin-RevId: 07fde9dedb07a85020b9fbc34658ee66823f687b
This commit is contained in:
Ruslan Cheremin
2025-07-19 20:56:53 +00:00
committed by intellij-monorepo-bot
parent 500af3dd77
commit 48aaef0511
1 changed files with 21 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/platform-impl/src/com/intellij/openapi/vfs/newvfs/persistent/PersistentFSImpl.java
+21 -13
View File
@@ -43,6 +43,7 @@ import com.intellij.util.containers.HashingStrategy;
import com.intellij.util.containers.MostlySingularMultiMap;
import com.intellij.util.containers.MultiMap;
import com.intellij.util.io.ReplicatorInputStream;
import io.opentelemetry.api.metrics.BatchCallback;
import io.opentelemetry.api.metrics.Meter;
import it.unimi.dsi.fastutil.Hash;
import it.unimi.dsi.fastutil.ints.*;
@@ -111,6 +112,8 @@ public final class PersistentFSImpl extends PersistentFS implements Disposable {
/** How many times folder case-sensitivity was read from underlying FS */
private final AtomicLong caseSensitivityReads = new AtomicLong();
private final BatchCallback otelMonitoringHandle;
public PersistentFSImpl(@NotNull Application app) {
this.app = app;
@@ -162,7 +165,7 @@ public final class PersistentFSImpl extends PersistentFS implements Disposable {
// Services might throw `AlreadyDisposedException`-s after and we have to suppress those exceptions or wrap with PCE-s.
ShutDownTracker.getInstance().registerCacheShutdownTask(this::disconnect);
setupOTelMonitoring(TelemetryManager.getInstance().getMeter(PlatformScopesKt.VFS));
otelMonitoringHandle = setupOTelMonitoring(TelemetryManager.getInstance().getMeter(PlatformScopesKt.VFS));
LOG.info("VFS.MAX_FILE_LENGTH_TO_CACHE: " + PersistentFSConstants.MAX_FILE_LENGTH_TO_CACHE);
}
@@ -273,6 +276,7 @@ public final class PersistentFSImpl extends PersistentFS implements Disposable {
LOG.warn("Detected cancellation during dispose of PersistentFS. Application was likely closed before VFS got completely initialized",
e);
}
otelMonitoringHandle.close();
}
@Override
@@ -2614,23 +2618,27 @@ public final class PersistentFSImpl extends PersistentFS implements Disposable {
}
}
private void setupOTelMonitoring(@NotNull Meter meter) {
private BatchCallback setupOTelMonitoring(@NotNull Meter meter) {
var fileByIdCacheHitsCounter = meter.counterBuilder("VFS.fileByIdCache.hits").buildObserver();
var fileByIdCacheMissesCounter = meter.counterBuilder("VFS.fileByIdCache.misses").buildObserver();
var fileChildByNameCounter = meter.counterBuilder("VFS.fileChildByName").buildObserver();
var caseSensitivityReadsCounter = meter.counterBuilder("VFS.folderCaseSensitivityReads").buildObserver();
var invertedFileNameIndexRequestsCount = meter.counterBuilder("VFS.invertedFileNameIndex.requests").buildObserver();
meter.batchCallback(() -> {
fileByIdCacheHitsCounter.record(fileByIdCacheHits.get());
fileByIdCacheMissesCounter.record(fileByIdCacheMisses.get());
fileChildByNameCounter.record(childByName.get());
caseSensitivityReadsCounter.record(caseSensitivityReads.get());
FSRecordsImpl vfs = vfsPeer;
if (vfs != null) {
invertedFileNameIndexRequestsCount.record(vfs.invertedNameIndexRequestsServed());
}
}, fileByIdCacheHitsCounter, fileByIdCacheMissesCounter, fileChildByNameCounter, caseSensitivityReadsCounter,
invertedFileNameIndexRequestsCount);
return meter.batchCallback(
() -> {
fileByIdCacheHitsCounter.record(fileByIdCacheHits.get());
fileByIdCacheMissesCounter.record(fileByIdCacheMisses.get());
fileChildByNameCounter.record(childByName.get());
caseSensitivityReadsCounter.record(caseSensitivityReads.get());
FSRecordsImpl vfs = vfsPeer;
if (vfs != null) {
invertedFileNameIndexRequestsCount.record(vfs.invertedNameIndexRequestsServed());
}
},
fileByIdCacheHitsCounter, fileByIdCacheMissesCounter, fileChildByNameCounter,
caseSensitivityReadsCounter,
invertedFileNameIndexRequestsCount
);
}
private static class LengthAndContentIdReader implements RecordReader<LengthAndContentIdReader> {