MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

Clarification comment about relational precedence

Browse Source 
Review ID: IDEA-CR-32780
This commit is contained in:
Tagir Valeev
2018-05-24 10:54:59 +07:00
parent 9e50dfae2f
commit 48927fa804
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/SimplifiableConditionalExpressionInspection.java
+7 -4
View File
@@ -89,12 +89,15 @@ public class SimplifiableConditionalExpressionInspection extends BaseInspection
assert thenExpression != null;
assert elseExpression != null;
if (BoolUtils.areExpressionsOpposite(thenExpression, elseExpression)) {
// EQUALITY_PRECEDENCE is technically enough here, but it may produces quite confusing code like "a == b > c"
// so we add (formally redundant) parentheses in this case: "a == (b > c)"
final int precedence = PsiPrecedenceUtil.RELATIONAL_PRECEDENCE;
if (BoolUtils.isNegation(thenExpression)) {
return ParenthesesUtils.getText(tracker.markUnchanged(condition), PsiPrecedenceUtil.RELATIONAL_PRECEDENCE) + " != " +
ParenthesesUtils.getText(tracker.markUnchanged(elseExpression), PsiPrecedenceUtil.RELATIONAL_PRECEDENCE);
return ParenthesesUtils.getText(tracker.markUnchanged(condition), precedence) + " != " +
ParenthesesUtils.getText(tracker.markUnchanged(elseExpression), precedence);
} else {
return ParenthesesUtils.getText(tracker.markUnchanged(condition), PsiPrecedenceUtil.RELATIONAL_PRECEDENCE) + " == " +
ParenthesesUtils.getText(tracker.markUnchanged(thenExpression), PsiPrecedenceUtil.RELATIONAL_PRECEDENCE);
return ParenthesesUtils.getText(tracker.markUnchanged(condition), precedence) + " == " +
ParenthesesUtils.getText(tracker.markUnchanged(thenExpression), precedence);
}
}
if (BoolUtils.isTrue(thenExpression)) {