MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

devkit: don't highlight usages of Pair constructor if diamonds can be used

Browse Source 
new Pair<>(...) is shorter than Pair.create so it makes no sense to highlight usages of Pair constructor if language level is 1.7 or newer.
This commit is contained in:
nik
2017-04-07 13:55:25 +03:00
parent af675743e3
commit 46a7dbfc0d
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/devkit/src/inspections/internal/DontUseNewPairInspection.java
+3 -1
View File
@@ -17,7 +17,9 @@ package org.jetbrains.idea.devkit.inspections.internal;
import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.codeInspection.ProblemsHolder;
import com.intellij.pom.java.LanguageLevel;
import com.intellij.psi.*;
import com.intellij.psi.util.PsiUtil;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.idea.devkit.inspections.DevKitInspectionBase;
import org.jetbrains.idea.devkit.inspections.quickfix.ChangeToPairCreateQuickFix;
@@ -41,7 +43,7 @@ public class DontUseNewPairInspection extends DevKitInspectionBase {
&& ((PsiClassType)type).rawType().equalsToText(PAIR_FQN)
&& params != null
&& expression.getArgumentList() != null
//&& !PsiUtil.getLanguageLevel(expression).isAtLeast(LanguageLevel.JDK_1_7) //diamonds
&& !PsiUtil.getLanguageLevel(expression).isAtLeast(LanguageLevel.JDK_1_7) //diamonds
) {
final PsiType[] types = ((PsiClassType)type).getParameters();
if (Arrays.equals(types, params.getExpressionTypes())) {