MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-04-19 04:51:24 +07:00
Code Issues Packages Projects Releases Wiki Activity

anonym -> lambda: do not suggest when forward references are detected (IDEA-120699)

Browse Source
This commit is contained in:
Anna Kozlova
2014-02-24 21:01:00 +01:00
parent b716f4763b
commit 44dde647bb
4 changed files with 33 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
java/java-analysis-impl/src/com/intellij/codeInspection/AnonymousCanBeLambdaInspection.java
View File

@@ -130,10 +130,12 @@ public class AnonymousCanBeLambdaInspection extends BaseJavaBatchLocalInspection
final PsiField field = PsiTreeUtil.getParentOfType(expression, PsiField.class);
if (field != null) {
final PsiElement resolved = expression.resolve();
if (resolved instanceof PsiField &&
!((PsiField)resolved).hasInitializer() &&
((PsiField)resolved).getContainingClass() == field.getContainingClass()) {
bodyContainsForbiddenRefs[0] = true;
if (resolved instanceof PsiField && ((PsiField)resolved).getContainingClass() == field.getContainingClass()) {
final PsiExpression initializer = ((PsiField)resolved).getInitializer();
if (initializer == null ||
initializer.getTextOffset() > aClass.getTextOffset() && !((PsiField)resolved).hasModifierProperty(PsiModifier.STATIC)) {
bodyContainsForbiddenRefs[0] = true;
}
}
}
}

7
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/anonymous2lambda/afterForwardStaticFieldReference.java Normal file
View File

@@ -0,0 +1,7 @@
// "Replace with lambda" "true"
class HelloLambda {
private final Runnable r = () -> {
System.out.println(x);
};
private static int x = 0;
}

10
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/anonymous2lambda/beforeForwardFieldReference.java Normal file
View File

@@ -0,0 +1,10 @@
// "Replace with lambda" "false"
class HelloLambda {
private final Runnable r = new Run<caret>nable() {
@Override
public void run() {
System.out.println(x);
}
};
private int x = 0;
}

10
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/anonymous2lambda/beforeForwardStaticFieldReference.java Normal file
View File

@@ -0,0 +1,10 @@
// "Replace with lambda" "true"
class HelloLambda {
private final Runnable r = new Run<caret>nable() {
@Override
public void run() {
System.out.println(x);
}
};
private static int x = 0;
}