MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

[plugins] refactor PluginSetBuilder: extract createCannotLoadError usage when errors is null

Browse Source 
GitOrigin-RevId: afb8bdafb4793bd349d5c2524c6e7565eee940fe
This commit is contained in:
Vadim Salavatov
2025-10-13 13:53:25 +00:00
committed by intellij-monorepo-bot
parent 6656efe42c
commit 449efe8694
1 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/core-impl/src/com/intellij/ide/plugins/PluginSetBuilder.kt
+15 -2
View File
@@ -110,11 +110,10 @@ class PluginSetBuilder(@JvmField val unsortedPlugins: Set<PluginMainDescriptor>)
val isDisabledDueToPackagePrefixConflict = HashMap<PluginModuleId, IdeaPluginDescriptorImpl>()
fun registerLoadingError(plugin: IdeaPluginDescriptorImpl, disabledModule: ContentModuleDescriptor) {
loadingErrors.add(createCannotLoadError(
loadingErrors.add(createCannotLoadError2(
descriptor = plugin,
dependencyPluginId = disabledModuleToProblematicPlugin.get(disabledModule.moduleId)
?: disabledModule.parent.pluginId,
errors = emptyMap(),
isNotifyUser = !plugin.isImplementationDetail))
}
fun markRequiredModulesAsDisabled(plugin: PluginMainDescriptor) {
@@ -362,6 +361,20 @@ private fun createCannotLoadError(
}
}
private fun createCannotLoadError2(
descriptor: IdeaPluginDescriptorImpl,
dependencyPluginId: PluginId,
isNotifyUser: Boolean,
): PluginNonLoadReason {
val dependencyIdString = dependencyPluginId.idString
val dependency = null
return if (dependency != null) {
PluginDependencyCannotBeLoaded(descriptor, dependencyIdString, isNotifyUser)
} else {
PluginDependencyIsNotInstalled(descriptor, dependencyIdString, isNotifyUser)
}
}
private fun getAllPluginDependencies(plugin: IdeaPluginDescriptorImpl): Sequence<PluginId> {
return plugin.dependencies.asSequence()
.filterNot { it.isOptional }