MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

equals/hashCode generation: simplify Objects.equals when fields are notNull (IDEA-194650)

Browse Source
This commit is contained in:
Anna.Kozlova
2018-07-09 19:46:44 +02:00
parent d8a462b31f
commit 449b375178
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-impl/src/com/intellij/codeInsight/generation/objectsEquals.vm
+2
View File
@@ -23,6 +23,8 @@ Object $paramName){
#addPrimitiveFieldComparisonConditionDirect($field) ##
#elseif ($field.array)
java.util.Arrays.equals($field.accessor, ${classInstanceName}.$field.accessor)##
#elseif ($field.notNull)
${field.accessor}.equals(${classInstanceName}.$field.accessor)##
#else
java.util.Objects.equals($field.accessor, ${classInstanceName}.$field.accessor)##
#end
java/java-tests/testData/codeInsight/generateEquals/afterArrayAndNotOnlyArrayWithObjectsTemplate.java
+1 -1
View File
@@ -13,7 +13,7 @@ class A {
if (o == null || getClass() != o.getClass()) return false;
final A a = (A) o;
return i == a.i &&
Objects.equals(s, a.s) &&
s.equals(a.s) &&
Arrays.equals(a1, a.a1) &&
Arrays.equals(a2, a.a2);
}