MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-01-08 15:09:39 +07:00
Code Issues Packages Projects Releases Wiki Activity

[jvm] Refactor JUnit rule tests

Browse Source 
GitOrigin-RevId: 4ee6cca502dd99ddfdafc31318a56b5d402ef19d
This commit is contained in:
Bart van Helvert
2022-03-10 17:42:32 +01:00
committed by intellij-monorepo-bot
parent 3750fb5139
commit 43f283d606
7 changed files with 69 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
jvm/jvm-analysis-kotlin-tests/testData/codeInspection/junitrule/ClassRule.kt
View File

@@ -1,13 +0,0 @@
package test
import org.junit.rules.TestRule
import org.junit.ClassRule
import test.SomeTestRule
object PrivateClassRule {
@ClassRule
private var <error descr="Fields annotated with '@org.junit.ClassRule' should be 'public'">x</error> = SomeTestRule()
@ClassRule
private var <error descr="Field type should be subtype of 'org.junit.rules.TestRule'"><error descr="Fields annotated with '@org.junit.ClassRule' should be 'public'">y</error></error> = 0
}

11
jvm/jvm-analysis-kotlin-tests/testData/codeInspection/junitrule/ClassRuleQf.after.kt
View File

@@ -1,11 +0,0 @@
package test
import org.junit.rules.TestRule
import org.junit.ClassRule
import test.SomeTestRule
object PrivateClassRule {
@kotlin.jvm.JvmField
@ClassRule
var x = SomeTestRule()
}

10
jvm/jvm-analysis-kotlin-tests/testData/codeInspection/junitrule/ClassRuleQf.kt
View File

@@ -1,10 +0,0 @@
package test
import org.junit.rules.TestRule
import org.junit.ClassRule
import test.SomeTestRule
object PrivateClassRule {
@ClassRule
private var x = SomeTestRule()
}

8
jvm/jvm-analysis-kotlin-tests/testData/codeInspection/junitrule/Rule.kt
View File

@@ -1,8 +0,0 @@
package test
import org.junit.Rule
class PrivateRule {
@Rule
private var <error descr="Fields annotated with '@org.junit.Rule' should be 'public'">x</error> = 0
}

9
jvm/jvm-analysis-kotlin-tests/testData/codeInspection/junitrule/RuleQf.after.kt
View File

@@ -1,9 +0,0 @@
package test
import org.junit.Rule
class PrivateRule {
@kotlin.jvm.JvmField
@Rule
var x = 0
}

8
jvm/jvm-analysis-kotlin-tests/testData/codeInspection/junitrule/RuleQf.kt
View File

@@ -1,8 +0,0 @@
package test
import org.junit.Rule
class PrivateRule {
@Rule
var x = 0
}

84
jvm/jvm-analysis-kotlin-tests/testSrc/com/intellij/codeInspection/tests/kotlin/KotlinJUnitRuleInspectionTest.kt
View File

@@ -1,32 +1,86 @@
package com.intellij.codeInspection.tests.kotlin
import com.intellij.codeInspection.tests.JUnitRuleInspectionTestBase
import com.intellij.jvm.analysis.KotlinJvmAnalysisTestUtil
import com.intellij.testFramework.TestDataPath
private const val inspectionPath = "/codeInspection/junitrule"
@TestDataPath("\$CONTENT_ROOT/testData$inspectionPath")
class KotlinJUnitRuleInspectionTest : JUnitRuleInspectionTestBase() {
override fun getBasePath() = KotlinJvmAnalysisTestUtil.TEST_DATA_PROJECT_RELATIVE_BASE_PATH + inspectionPath
fun `test @Rule highlighting`() {
myFixture.testHighlighting("Rule.kt")
myFixture.testHighlighting(ULanguage.KOTLIN, """
package test
import org.junit.Rule
class PrivateRule {
@Rule
private var <error descr="Fields annotated with '@org.junit.Rule' should be 'public'">x</error> = 0
}
""".trimIndent())
}
fun `test @Rule quickFixes`() {
val quickfixes = myFixture.getAllQuickFixes("RuleQf.kt")
quickfixes.forEach { myFixture.launchAction(it) }
myFixture.checkResultByFile("RuleQf.after.kt")
myFixture.testQuickFix(ULanguage.KOTLIN, """
package test
import org.junit.Rule
class PrivateRule {
@Rule
var x<caret> = 0
}
""".trimIndent(), """
package test
import org.junit.Rule
class PrivateRule {
@kotlin.jvm.JvmField
@Rule
var x = 0
}
""".trimIndent(), "Annotate as @JvmField")
}
fun `test @ClassRule highlighting`() {
myFixture.testHighlighting("ClassRule.kt")
myFixture.testHighlighting(ULanguage.KOTLIN, """
package test
import org.junit.rules.TestRule
import org.junit.ClassRule
import test.SomeTestRule
object PrivateClassRule {
@ClassRule
private var <error descr="Fields annotated with '@org.junit.ClassRule' should be 'public'">x</error> = SomeTestRule()
@ClassRule
private var <error descr="Field type should be subtype of 'org.junit.rules.TestRule'"><error descr="Fields annotated with '@org.junit.ClassRule' should be 'public'">y</error></error> = 0
}
""".trimIndent())
}
fun `test @ClassRule quickFixes`() {
val quickfixes = myFixture.getAllQuickFixes("ClassRuleQf.kt")
quickfixes.forEach { myFixture.launchAction(it) }
myFixture.checkResultByFile("ClassRuleQf.after.kt")
myFixture.testQuickFix(ULanguage.KOTLIN, """
package test
import org.junit.rules.TestRule
import org.junit.ClassRule
import test.SomeTestRule
object PrivateClassRule {
@ClassRule
private var x<caret> = SomeTestRule()
}
""".trimIndent(), """
package test
import org.junit.rules.TestRule
import org.junit.ClassRule
import test.SomeTestRule
object PrivateClassRule {
@kotlin.jvm.JvmField
@ClassRule
var x = SomeTestRule()
}
""".trimIndent(), "Remove 'private' modifier", "Annotate as @JvmField")
}
}