MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

CPP-8459: Move possibly lengthy isValid() computation out of the synchronized method

Browse Source 
Review: IDEA-CR-32023
This commit is contained in:
Dmitry Kozhevnikov
2018-05-30 14:02:29 +03:00
parent 3c9ad1cbbc
commit 42bde555b4
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/usageView/src/com/intellij/usages/impl/Node.java
+7 -1
View File
@@ -92,13 +92,19 @@ public abstract class Node extends DefaultMutableTreeNode {
return isFlagSet(EXCLUDED_MASK);
}
final synchronized void update(@NotNull UsageView view, @NotNull Consumer<? super Node> edtNodeChangedQueue) {
final void update(@NotNull UsageView view, @NotNull Consumer<? super Node> edtNodeChangedQueue) {
// performance: always update in background because smart pointer' isValid() can cause PSI chameleons expansion which is ridiculously expensive in cpp
assert !ApplicationManager.getApplication().isDispatchThread();
boolean isDataValid = isDataValid();
boolean isReadOnly = isDataReadOnly();
String text = getText(view);
doUpdate(edtNodeChangedQueue, isDataValid, isReadOnly, text);
}
private synchronized void doUpdate(@NotNull Consumer<? super Node> edtNodeChangedQueue,
boolean isDataValid,
boolean isReadOnly,
String text) {
boolean cachedValid = isValid();
boolean cachedReadOnly = isFlagSet(CACHED_READ_ONLY_MASK);